You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/03/26 03:29:09 UTC

(superset) branch template_less updated (023c7da07b -> 1afa4971d1)

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a change to branch template_less
in repository https://gitbox.apache.org/repos/asf/superset.git


    from 023c7da07b fix another test
     new aabeefb761 fix types in Gauge/transformProps.test.ts
     new 5418f09864 fix test for BasicErrorAlert.tsx
     new 1afa4971d1 fix SavedQueries test

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../plugin-chart-echarts/test/Gauge/transformProps.test.ts     | 10 +++++-----
 .../src/components/ErrorMessage/BasicErrorAlert.tsx            |  6 +-----
 superset-frontend/src/features/home/SavedQueries.tsx           |  2 +-
 3 files changed, 7 insertions(+), 11 deletions(-)


(superset) 02/03: fix test for BasicErrorAlert.tsx

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch template_less
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 5418f09864c8beacf9cd0aab78a8bee0e9fce8f2
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Mar 25 20:24:56 2025 -0700

    fix test for BasicErrorAlert.tsx
---
 superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx b/superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx
index 26f147bb73..1129683b75 100644
--- a/superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx
+++ b/superset-frontend/src/components/ErrorMessage/BasicErrorAlert.tsx
@@ -57,11 +57,7 @@ export default function BasicErrorAlert({
 
   return (
     <div style={style} role="alert">
-      {level === 'error' ? (
-        <Icons.ErrorSolid iconColor={variants.text} />
-      ) : (
-        <Icons.WarningSolid iconColor={variants.text} />
-      )}
+      <Icons.ExclamationCircleFilled iconColor={variants.text} />
       <StyledContent>
         <StyledTitle>{title}</StyledTitle>
         <p>{body}</p>


(superset) 01/03: fix types in Gauge/transformProps.test.ts

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch template_less
in repository https://gitbox.apache.org/repos/asf/superset.git

commit aabeefb761e5e6d4296853d6cd992eea7f09ea35
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Mar 25 20:17:59 2025 -0700

    fix types in Gauge/transformProps.test.ts
---
 .../plugin-chart-echarts/test/Gauge/transformProps.test.ts     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/plugins/plugin-chart-echarts/test/Gauge/transformProps.test.ts b/superset-frontend/plugins/plugin-chart-echarts/test/Gauge/transformProps.test.ts
index 713ebc9f2d..a07977af66 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/test/Gauge/transformProps.test.ts
+++ b/superset-frontend/plugins/plugin-chart-echarts/test/Gauge/transformProps.test.ts
@@ -82,7 +82,7 @@ describe('Echarts Gauge transformProps', () => {
     expect(result.height).toBe(600);
 
     // Test series data
-    const seriesData = result.echartOptions.series[0].data;
+    const seriesData = (result.echartOptions as any).series[0].data;
     expect(seriesData).toHaveLength(1);
     expect(seriesData[0].value).toBe(16595);
     expect(seriesData[0].name).toBe('');
@@ -132,7 +132,7 @@ describe('Echarts Gauge transformProps', () => {
     expect(result.height).toBe(600);
 
     // Test series data
-    const seriesData = result.echartOptions.series[0].data;
+    const seriesData = (result.echartOptions as any).series[0].data;
     expect(seriesData).toHaveLength(2);
 
     // First data point
@@ -193,7 +193,7 @@ describe('Echarts Gauge transformProps', () => {
     expect(result.height).toBe(600);
 
     // Test series data
-    const seriesData = result.echartOptions.series[0].data;
+    const seriesData = (result.echartOptions as any).series[0].data;
     expect(seriesData).toHaveLength(2);
 
     // First data point
@@ -257,7 +257,7 @@ describe('Echarts Gauge transformProps', () => {
     expect(result.height).toBe(600);
 
     // Test axisLine intervals
-    const { axisLine } = result.echartOptions.series[0];
+    const { axisLine } = (result.echartOptions as any).series[0];
     expect(axisLine.roundCap).toBe(false);
     expect(axisLine.lineStyle.width).toBe(14);
     expect(axisLine.lineStyle.color).toEqual([
@@ -266,7 +266,7 @@ describe('Echarts Gauge transformProps', () => {
     ]);
 
     // Test series data
-    const seriesData = result.echartOptions.series[0].data;
+    const seriesData = (result.echartOptions.series as any)[0].data;
     expect(seriesData).toHaveLength(2);
 
     // First data point


(superset) 03/03: fix SavedQueries test

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch template_less
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 1afa4971d1293ca325178f8fbbce5234ea1e04ee
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Mar 25 20:28:44 2025 -0700

    fix SavedQueries test
---
 superset-frontend/src/features/home/SavedQueries.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/features/home/SavedQueries.tsx b/superset-frontend/src/features/home/SavedQueries.tsx
index fccb88c3ad..91c1dfd7db 100644
--- a/superset-frontend/src/features/home/SavedQueries.tsx
+++ b/superset-frontend/src/features/home/SavedQueries.tsx
@@ -347,7 +347,7 @@ export const SavedQueries = ({
                         trigger={['click', 'hover']}
                       >
                         <Button buttonSize="xsmall" buttonStyle="link">
-                          <Icons.MoreVert iconColor={theme.colorText} />
+                          <Icons.MoreOutlined iconColor={theme.colorText} />
                         </Button>
                       </Dropdown>
                     </ListViewCard.Actions>