[PR] build: repopulate TypeMeta after client.Get to avoid event recorder nil deref [camel-k]

["SAY-5 (via GitHub)" <gi...@apache.org>]

SAY-5 opened a new pull request, #6601:
URL: https://github.com/apache/camel-k/pull/6601

   Fixes #6587.
   
   After PR #6492 migrated the build controller from `record.EventRecorder` to `events.EventRecorder`, every event publish went through `reference.GetReference(scheme, obj)` which calls `obj.GetObjectKind()`. controller-runtime strips `TypeMeta` from objects returned by `client.Get` (kubernetes-sigs/controller-runtime#1735), so `GetObjectKind()` nil-derefs and the build controller panics on every reconcile.
   
   Repopulate `TypeMeta` immediately after `client.Get` returns. The same pattern likely affects the pipe, integration, integrationkit, integrationplatform, and catalog controllers (all migrated to `events.EventRecorder`); happy to send a sibling PR if you'd like the sweep, but filing Build alone first per the issue scope.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] build: repopulate TypeMeta after client.Get to avoid event recorder nil deref [camel-k]

["SAY-5 (via GitHub)" <gi...@apache.org>]

SAY-5 closed pull request #6601: build: repopulate TypeMeta after client.Get to avoid event recorder nil deref
URL: https://github.com/apache/camel-k/pull/6601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] build: repopulate TypeMeta after client.Get to avoid event recorder nil deref [camel-k]

["SAY-5 (via GitHub)" <gi...@apache.org>]

SAY-5 commented on PR #6601:
URL: https://github.com/apache/camel-k/pull/6601#issuecomment-4392282800

   Closing in favor of #6589 — thanks @squakez!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org