[jira] [Updated] (YETUS-40) patch file confuses test-patch (date format problems)

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YETUS-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated YETUS-40:
----------------------------------
    Attachment: YETUS-40.04.patch

Thanks for the review! I know this is a weird/hard one.

-04:
* Fixes for [~sekikn]'s points.

bq.     s/YETUS_SHELL_SCRIPT_DEBUG/TP_SHELL_SCRIPT_DEBUG/

Actually, I meant to do this the opposite way, now that this code is touch more than just test-patch.  As we add more shell code, having some standard vars across all of the shell code will be handy.

bq.     Should guess_patch_file return 1 if patchfile_dryrun_driver returns 1?

Yes.  At this point, we can be certain that it's either not a patch or a patch format we can't apply.  So the result code of patchfile_dryrun_driver gets passed back through guess_patch_file.

> patch file confuses test-patch (date format problems)
> -----------------------------------------------------
>
>                 Key: YETUS-40
>                 URL: https://issues.apache.org/jira/browse/YETUS-40
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: HADOOP-12326.002.patch, HADOOP-12375.HADOOP-12111.02.patch, YETUS-40.00.patch, YETUS-40.01.patch, YETUS-40.02.patch, YETUS-40.03.patch, YETUS-40.04.patch
>
>
> This was attached to HADOOP-12326 .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)