You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/06/16 17:20:51 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/466
CLOUDSTACK-8545 make reboot on out of band migration configurable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack 4.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 68a4d5f9d457734279a987e028690d72b2815439
Author: Daan Hoogland <da...@gmail.com>
Date: 2015-06-16T15:12:43Z
CLOUDSTACK-8545 make reboot on out of band migration configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Posted by anshul1886 <gi...@git.apache.org>.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-113046025
Yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Posted by anshul1886 <gi...@git.apache.org>.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112649249
We should generate alert when out of band router VM migration is detected. This will help user take appropriate action in those scenarios.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112794173
travis timeout, will ignore again. hoping the pull request builder does better.
@resmo to 4.5 yes, to master no. master has persistant config and routers will respin fully configured there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112762271
@DaanHoogland thanks for picking it up, btw do you port plan to fix it in 4.5 and master as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112917890
@anshul1886 would the following satisfy your needs (had some extra time)
+ } else {
+ if (isOutOfBandMigrated(opaque)) {
+ final String title = "Router has been migrated out of band: " + vo.getInstanceName();
+ final String context =
+ "An out of band migration of router " + vo.getInstanceName() + "(" + vo.getUuid() + ") was detected. No automated action was performed.";
+ _alertMgr.sendAlert(AlertManager.AlertType.ALERT_TYPE_DOMAIN_ROUTER, vo.getDataCenterId(), vo.getPodIdToDeployIn(), title, context);
+ }
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot
on out of ban...
Posted by Remi Bergsma <RB...@schubergphilis.com>.
Thanks for picking this up!
LGTM, I'll try to test it tomorrow.
One comment: I'd propose the setting name to reflect 'out of band'. Now it looks like when you migrate a router in ACS it will also reboot.
router.reboot.when.outofband.migrated?
Regards, Remi
Sent from my iPhone
> On 16 Jun w2015, at 17:20, DaanHoogland <gi...@git.apache.org> wrote:
>
> GitHub user DaanHoogland opened a pull request:
>
> https://github.com/apache/cloudstack/pull/466
>
> CLOUDSTACK-8545 make reboot on out of band migration configurable
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/DaanHoogland/cloudstack 4.4
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/466.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #466
>
> ----
> commit 68a4d5f9d457734279a987e028690d72b2815439
> Author: Daan Hoogland <da...@gmail.com>
> Date: 2015-06-16T15:12:43Z
>
> CLOUDSTACK-8545 make reboot on out of band migration configurable
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/466#issuecomment-112686118
@remibergsma makes sense, will do
@anshul1886 feel free to amend, I do not consider your proposed extension part of this blocker though it makes perfect sense from a functional perspective.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---