You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/26 11:05:09 UTC
[GitHub] tillrohrmann commented on a change in pull request #7808:
[FLINK-11718][rpc] Add onStart method to RpcEndpoint
tillrohrmann commented on a change in pull request #7808: [FLINK-11718][rpc] Add onStart method to RpcEndpoint
URL: https://github.com/apache/flink/pull/7808#discussion_r260234414
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -322,7 +317,7 @@ public void start() {
*/
public CompletableFuture<Acknowledge> start(final JobMasterId newJobMasterId) throws Exception {
// make sure we receive RPC and async calls
- super.start();
+ start();
return callAsyncWithoutFencing(() -> startJobExecution(newJobMasterId), RpcUtils.INF_TIMEOUT);
Review comment:
No, because `start` is not being executed in the main thread and we guarantee that `onStart` is always executed by the main thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services