You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "FangYongs (via GitHub)" <gi...@apache.org> on 2023/08/02 03:36:42 UTC

[GitHub] [flink] FangYongs commented on pull request #23101: [FLINK-32667][dispatcher] Do not save job without restart strategy to job writer and store

FangYongs commented on PR #23101:
URL: https://github.com/apache/flink/pull/23101#issuecomment-1661439688

   Thanks @XComp for you advice. I have carefully considered it and I think your approach is much better! I have found that the current method, in addition to the issues you mentioned, will also cause many testing errors because it is not compatible enough with the saving and deleting jobgraph. I will update this PR to use a delegate implementation for `JobGraphWriter`.
   
   For `JobResultStore`, it will be used in `Dispatcher` and `JobMasterServiceLeadershipRunner` to check whether there's duplicate job for given id, and then save job information to filesystem after it reaches terminations. I agree with you that we can consider it when it really been an issue later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org