[jira] [Commented] (SOLR-15076) Inconsistent metric types in ReplicationHandler

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271388#comment-17271388 ] 

ASF subversion and git services commented on SOLR-15076:
--------------------------------------------------------

Commit 166d39a12eff53d9cfdf47b101cfe98a7020dcba in lucene-solr's branch refs/heads/master from Andrzej Bialecki
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=166d39a ]

SOLR-15076: Fix wrong test assumption - type of this property has changed
in SOLR-14924.


> Inconsistent metric types in ReplicationHandler
> -----------------------------------------------
>
>                 Key: SOLR-15076
>                 URL: https://issues.apache.org/jira/browse/SOLR-15076
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Andrzej Bialecki
>            Assignee: Andrzej Bialecki
>            Priority: Major
>             Fix For: 8.9
>
>
> As pointed out by [~dsmiley] in SOLR-14924 there are cases when ReplicaHandler returns unexpected type of a metric (string instead of a number):
> {quote}
> There are test failures in TestReplicationHandler introduced by this change (I think). See https://ci-builds.apache.org/job/Lucene/job/Lucene-Solr-Tests-8.x/1255/
> java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String
>  at __randomizedtesting.SeedInfo.seed([754427253A1E4E95:F190450AC46671D]:0)
>  at org.apache.solr.handler.TestReplicationHandler.doTestDetails(TestReplicationHandler.java:361)
> The test could be made to convert to a string. But it suggests an inconsistency that ought to be fixed – apparently ReplicationHandler sometimes returns its details using all strings and othertimes with the typed variants – and that's bad.
> {quote}
> Reproducing seed from David:
> {quote}
> gradlew :solr:core:test --tests "org.apache.solr.handler.TestReplicationHandler.doTestDetails" -Ptests.jvms=6 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=5135EC61BF449203 -Ptests.file.encoding=ISO-8859-1
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org