You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by gr...@apache.org on 2020/06/05 21:45:13 UTC
[incubator-superset] branch master updated: fix: [logging] fix
render chart error type (#10000)
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 656cdfb fix: [logging] fix render chart error type (#10000)
656cdfb is described below
commit 656cdfb86709fa525c1122e359d2e767c6174351
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Fri Jun 5 14:44:52 2020 -0700
fix: [logging] fix render chart error type (#10000)
---
superset-frontend/src/chart/Chart.jsx | 4 ++--
superset-frontend/src/logger/LogUtils.js | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/chart/Chart.jsx b/superset-frontend/src/chart/Chart.jsx
index 5fc9bc8..4205360 100644
--- a/superset-frontend/src/chart/Chart.jsx
+++ b/superset-frontend/src/chart/Chart.jsx
@@ -21,7 +21,7 @@ import React from 'react';
import { Alert } from 'react-bootstrap';
import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
-import { Logger, LOG_ACTIONS_RENDER_CHART_CONTAINER } from '../logger/LogUtils';
+import { Logger, LOG_ACTIONS_RENDER_CHART } from '../logger/LogUtils';
import Loading from '../components/Loading';
import RefreshChartOverlay from '../components/RefreshChartOverlay';
import ErrorMessageWithStackTrace from '../components/ErrorMessage/ErrorMessageWithStackTrace';
@@ -128,7 +128,7 @@ class Chart extends React.PureComponent {
info ? info.componentStack : null,
);
- actions.logEvent(LOG_ACTIONS_RENDER_CHART_CONTAINER, {
+ actions.logEvent(LOG_ACTIONS_RENDER_CHART, {
slice_id: chartId,
has_err: true,
error_details: error.toString(),
diff --git a/superset-frontend/src/logger/LogUtils.js b/superset-frontend/src/logger/LogUtils.js
index 14299aa..17e4a0f 100644
--- a/superset-frontend/src/logger/LogUtils.js
+++ b/superset-frontend/src/logger/LogUtils.js
@@ -25,7 +25,6 @@ export const LOG_ACTIONS_MOUNT_DASHBOARD = 'mount_dashboard';
export const LOG_ACTIONS_MOUNT_EXPLORER = 'mount_explorer';
export const LOG_ACTIONS_SELECT_DASHBOARD_TAB = 'select_dashboard_tab';
-export const LOG_ACTIONS_RENDER_CHART_CONTAINER = 'render_chart_container';
export const LOG_ACTIONS_FORCE_REFRESH_CHART = 'force_refresh_chart';
export const LOG_ACTIONS_CHANGE_EXPLORE_CONTROLS = 'change_explore_controls';
export const LOG_ACTIONS_TOGGLE_EDIT_DASHBOARD = 'toggle_edit_dashboard';
@@ -57,7 +56,6 @@ export const LOG_EVENT_TYPE_USER = new Set([
LOG_ACTIONS_PERIODIC_RENDER_DASHBOARD,
LOG_ACTIONS_OMNIBAR_TRIGGERED,
LOG_ACTIONS_MOUNT_EXPLORER,
- LOG_ACTIONS_RENDER_CHART_CONTAINER,
]);
export const Logger = {