[GitHub] [hadoop] ashutoshcipher commented on pull request #4229: HADOOP-18069. okhttp@2.7.5 to 4.9.3

[GitBox <gi...@apache.org>]

ashutoshcipher commented on PR #4229:
URL: https://github.com/apache/hadoop/pull/4229#issuecomment-1117265531

   > > spotbugs still thinks there is a problem. what is it that it is warning about?
   > > I already used try-with-resources for OkHttpClient and added request checks as well. The warning is about NPE case.
   > 
   > Reading the source code, `responseBody.body()` is always non-null. However, spotbugs thinks `responseBody.body()` may be null and it warns "need null check". I think it is because Spotbugs failed to analyze the okhttp classes from Kotlin.
   > 
   > I think we can simply ignore the warnings. @ashutoshcipher would you add some entries to ignore the spotbugs warning in `hadoop-hdfs-project/hadoop-hdfs-client/dev-support/findbugsExcludeFile.xml`?
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org