You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/09/01 22:59:07 UTC
[GitHub] [cordova-plugin-statusbar] jcesarmobile opened a new pull request, #238: fix(android)!:styleDefault not working on new devices
jcesarmobile opened a new pull request, #238:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/238
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
android
### Motivation and Context
styleDefault is not working on some Android 12/13 devices, this PR makes it work again.
### Description
The PR uses `WindowInsetsControllerCompat.setAppearanceLightStatusBars` instead of the deprecated `SYSTEM_UI_FLAG_LIGHT_STATUS_BAR`. Makes `styleDefault` work on new devices.
It's a breaking change because it requires `androidx.core`, which is only available on cordova-android >= 9. At the moment the plugin doesn't have any cordova-android version requirement, so requiring cordova-android >= 9 is breaking.
A separate PR would be sent to set the engines if this PR gets accepted.
closes https://github.com/apache/cordova-plugin-statusbar/issues/236
closes https://github.com/apache/cordova-plugin-statusbar/pull/235, which is a similar PR but uses deprecated methods.
### Testing
Tested on real devices and emulators
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] jcesarmobile merged pull request #238: fix(android)!: styleDefault not working on new devices
Posted by GitBox <gi...@apache.org>.
jcesarmobile merged PR #238:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org