You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/03 03:21:11 UTC
[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18845: Fixed python website double scroller and improve UX
ys2843 opened a new pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845
## Description ##
fix #18838 and improve user experience of python site.
### Changes ###
- [ ] Fixed double scroller
- [ ] Added scroll aware animation to top nav bar
- [ ] Reduce the height of the second top nav bar to hide it when scrolling down
## Comments ##
- Preview: http://ec2-18-236-134-13.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/index.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18845: Fixed python website double scroller and improve UX
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845#issuecomment-668201730
awesome! things are working as expected now. thanks for making the browsing experience smooth!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18845: Fixed python website double scroller and improve UX
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845#issuecomment-667782118
Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, edge, unix-cpu, miscellaneous, website, windows-cpu, centos-gpu, unix-gpu, clang, centos-cpu, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #18845: Fixed python website double scroller and improve UX
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845#issuecomment-667790836
@ys2843 thanks for the fix! I verified that the double scroller problem is gone and the page seems to run smoother too.
I tried page-up and page-down but it still doesn't seem to work unless I click on the inner div to adjust the focus first. Is there any way to make page scrolling with keyboard work too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18845: Fixed python website double scroller and improve UX
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845#issuecomment-667782304
@mxnet-label-bot add [Website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18845: Fixed python website double scroller and improve UX
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845#issuecomment-667830263
> @ys2843 thanks for the fix! I verified that the double scroller problem is gone and the page seems to run smoother too.
> I tried page-up and page-down but it still doesn't seem to work unless I click on the inner div to adjust the focus first. Is there any way to make page scrolling with keyboard work too?
Thanks for reviewing, the keyboard control depends on the focused element. I added a fix to auto focus the content element when the pages finish rendering. Please see the (updated) preview.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18845: Fixed python website double scroller and improve UX
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18845:
URL: https://github.com/apache/incubator-mxnet/pull/18845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org