[jira] Closed: (HARMONY-3198) [drlvm][winx64] several uncertain changes need careful review

["Gregory Shimansky (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HARMONY-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-3198.
--------------------------------------


No response, assuming ok.

> [drlvm][winx64] several uncertain changes need careful review
> -------------------------------------------------------------
>
>                 Key: HARMONY-3198
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3198
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: windows/em64t
>            Reporter: Ivan Zvolsky
>            Assignee: Gregory Shimansky
>         Attachments: H3198.patch
>
>
> drlvm_need_impl.patch also contains 3 somewhat questionable changes:
> 1) line 11: drlvm didn't compile with 'private' modifier under windows/em64t but compiler fine without. I workarounded this by removing it for windows/em64t, but the modifier certainly needs to be there.
> 2) line 28: same as above - the line must be uncommented, but I couldn't find the way to fix compilation problem quickly, so I removed the line for windows/em64t.
> 3) line 113: couldn't compile that "as is", so had to replace the line with something different, but i'm not sure they are equivalent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.