You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/18 16:15:13 UTC
[GitHub] [incubator-tvm] rkimball opened a new pull request #6514: Change some tutorial text
rkimball opened a new pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514
I had a few issues following the how to install from source on linux so I addressed them here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#issuecomment-694957978
@tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491073341
##########
File path: docs/install/from_source.rst
##########
@@ -174,12 +174,12 @@ Method 1
Set the environment variable `PYTHONPATH` to tell python where to find
the library. For example, assume we cloned `tvm` on the home directory
- `~`. then we can added the following line in `~/.bashrc`.
+ `~` then we can add the following line in `~/.bashrc`.
The changes will be immediately reflected once you pull the code and rebuild the project (no need to call ``setup`` again)
.. code:: bash
- export TVM_HOME=/path/to/tvm
+ export TVM_HOME=~/tvm
Review comment:
Ah that's a good point. I'll prefer to keep `/path/to/tvm` and change to "For example, assume we cloned `tvm` to `/path/to/tvm` then..."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491064115
##########
File path: docs/install/from_source.rst
##########
@@ -174,12 +174,12 @@ Method 1
Set the environment variable `PYTHONPATH` to tell python where to find
the library. For example, assume we cloned `tvm` on the home directory
- `~`. then we can added the following line in `~/.bashrc`.
+ `~` then we can add the following line in `~/.bashrc`.
The changes will be immediately reflected once you pull the code and rebuild the project (no need to call ``setup`` again)
.. code:: bash
- export TVM_HOME=/path/to/tvm
+ export TVM_HOME=~/tvm
Review comment:
This may cause confusion since it's not necessary to put tvm under `$HOME`.
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
According to `python/setup.py`, the complete list should also include `scipy` and `psutil`, but not `pytest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#issuecomment-696770828
thanks @rkimball @comaniac @binarybana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] binarybana commented on a change in pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
binarybana commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491138180
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
Also, we should eventually fix this properly with an official `requirements.txt` or `setup.py` set of dependencies, so people don't have to [roll their own lists](https://github.com/tlc-pack/tlcpack/blob/master/docker/install/centos_install_python_package.sh#L13-L16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] binarybana commented on a change in pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
binarybana commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491138180
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
Also, we should fix this properly with an official `requirements.txt` or `setup.py` set of dependencies, so people don't have to [roll their own lists](https://github.com/tlc-pack/tlcpack/blob/master/docker/install/centos_install_python_package.sh#L13-L16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r492068252
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
I think follow up PR to do what @binarybana suggests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491077138
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
I reverted this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491071999
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
I was following the instructions literally on a new ubuntu 20.04 install and these are the changes I needed to make to get the example to work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491617768
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
@rkimball would you prefer to add the unit test section in this PR or file a follow-up PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#issuecomment-696770828
thanks @rkimball @comaniac @binarybana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491076083
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
I see. Which example did you try? In general if users only want to use instead of developing TVM, we should not ask them to install unnecessary packages such as `pytest` and `mypy`.
IMHO, we could indicate an example at the end of this doc to make it clear. It might be better to also add descriptions about installing extra requirements for developments (e.g., testing).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491068243
##########
File path: docs/install/from_source.rst
##########
@@ -174,12 +174,12 @@ Method 1
Set the environment variable `PYTHONPATH` to tell python where to find
the library. For example, assume we cloned `tvm` on the home directory
- `~`. then we can added the following line in `~/.bashrc`.
+ `~` then we can add the following line in `~/.bashrc`.
The changes will be immediately reflected once you pull the code and rebuild the project (no need to call ``setup`` again)
.. code:: bash
- export TVM_HOME=/path/to/tvm
+ export TVM_HOME=~/tvm
Review comment:
I agree, but if you read the text preceding this statement it says
```For example, assume we cloned tvm on the home directory ~. then we can added the following line in ~/.bashrc```
Pasting the example code into your .bashrc file will not work since the /path/to/tvm is incorrect in this case. We can either remove the "For example..." text and leave `/path/to/tvm` or change the path to ~/tvm.
As it stands it is not correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491076980
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
That's a good idea to me 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: [DOCS] Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r492068252
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
I think follow up PR to do what @binarybana suggests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491077138
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
I reverted this change. To do this right I would need to start with a new clean linux install and go through the process to figure out what is needed for running unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491075223
##########
File path: docs/install/from_source.rst
##########
@@ -174,12 +174,12 @@ Method 1
Set the environment variable `PYTHONPATH` to tell python where to find
the library. For example, assume we cloned `tvm` on the home directory
- `~`. then we can added the following line in `~/.bashrc`.
+ `~` then we can add the following line in `~/.bashrc`.
The changes will be immediately reflected once you pull the code and rebuild the project (no need to call ``setup`` again)
.. code:: bash
- export TVM_HOME=/path/to/tvm
+ export TVM_HOME=~/tvm
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6514: Change some tutorial text
Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #6514:
URL: https://github.com/apache/incubator-tvm/pull/6514#discussion_r491076386
##########
File path: docs/install/from_source.rst
##########
@@ -205,7 +205,7 @@ like ``virtualenv``.
.. code:: bash
- pip3 install --user numpy decorator attrs
+ pip3 install --user numpy decorator attrs typed_ast pytest
Review comment:
Perhaps we can add a new section
* If you want to run unit tests
pip3 install --user ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org