[jira] [Commented] (KAFKA-6890) Add connector level configurability for producer/consumer client configs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470566#comment-16470566 ] 

ASF GitHub Bot commented on KAFKA-6890:
---------------------------------------

natengall opened a new pull request #4997: KAFKA-6890: Add connector-level configurability for client configs
URL: https://github.com/apache/kafka/pull/4997
 
 
   Introduced capability for individual connectors to override client config defaults.
   
   Connector properties that are prefixed with "producer." and "consumer." are now used to feed into the producer and consumer clients embedded within source and sink connectors respectively.
   
   Author: Allen Tang <na...@gmail.com>
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add connector level configurability for producer/consumer client configs
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-6890
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6890
>             Project: Kafka
>          Issue Type: New Feature
>          Components: KafkaConnect
>            Reporter: Allen Tang
>            Priority: Minor
>
> Right now, each source connector and sink connector inherit their client configurations from the worker properties. Within the worker properties, all configurations that have a prefix of "producer." or "consumer." are applied to all source connectors and sink connectors respectively.
> We should also provide connector-level overrides whereby connector properties that are prefixed with "producer." and "consumer." are used to feed into the producer and consumer clients embedded within source and sink connectors respectively. The prefixes will be removed via a String#substring() call, and the remainder of the connector property key will be used as the client configuration key. The value is fed directly to the client as the configuration value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)