You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2026/01/29 07:47:47 UTC
[PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Hisoka-X opened a new pull request, #4243:
URL: https://github.com/apache/flink-cdc/pull/4243
This pull request improves error reporting and debugging for transformation expressions in the Flink CDC runtime.
Currently, when a transformation used in `transform` encounters an error, we don't include the user-provided expression in the error message, making it difficult for users to directly determine the source of the error.
Before:
```
Failed to evaluate projection expression `castToTimestamp("FOOBAR", __time_zone__)` for column `comp_11` in table `foo.bar.baz`
```
After:
```
Failed to evaluate projection expression `CAST('FOOBAR' AS TIMESTAMP(6))` for column `comp_11` in table `foo.bar.baz`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian merged PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243#discussion_r2745263292
##########
flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java:
##########
@@ -2808,7 +2808,10 @@ void testTransformErrorMessage() {
.cause()
.isExactlyInstanceOf(RuntimeException.class)
.hasMessageContaining(
- "Failed to evaluate filtering expression `greaterThan($0 + 1, 0)` for table `default_namespace.default_schema.mytable1`")
+ "Failed to evaluate filtering expression for table `default_namespace.default_schema.mytable1`.\n"
+ + "\tOriginal expression: name + 1 > 0\n"
+ + "\tCompiled expression: greaterThan($0 + 1, 0)\n"
+ + "\tColumn name map: {$0 -> name}")
.hasMessageContaining("Column name map: {$0 -> name}")
Review Comment:
This assertion is redundant as the column name map is already verified as part of the full message assertion on lines 2810-2814. The `.hasMessageContaining("Column name map: {$0 -> name}")` check duplicates what was already asserted in the complete error message.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243#issuecomment-3822615974
Hi @yuxiqian, maybe you can help to review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243#issuecomment-3822096649
> Hi @Hisoka-X, you may need to rebase master to fix confilct.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243#issuecomment-3822040453
Hi @Hisoka-X, you may need to rebase master to fix confilct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38996][transform] Enhance error messages for projection and filtering expressions [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #4243:
URL: https://github.com/apache/flink-cdc/pull/4243#discussion_r2745378958
##########
flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java:
##########
@@ -2808,7 +2808,10 @@ void testTransformErrorMessage() {
.cause()
.isExactlyInstanceOf(RuntimeException.class)
.hasMessageContaining(
- "Failed to evaluate filtering expression `greaterThan($0 + 1, 0)` for table `default_namespace.default_schema.mytable1`")
+ "Failed to evaluate filtering expression for table `default_namespace.default_schema.mytable1`.\n"
+ + "\tOriginal expression: name + 1 > 0\n"
+ + "\tCompiled expression: greaterThan($0 + 1, 0)\n"
+ + "\tColumn name map: {$0 -> name}")
.hasMessageContaining("Column name map: {$0 -> name}")
Review Comment:
True, but not a major problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org