You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by em...@apache.org on 2021/08/10 04:34:57 UTC

[arrow] branch master updated: ARROW-13172: [Java] Make TYPE_WIDTH publicly accessible

This is an automated email from the ASF dual-hosted git repository.

emkornfield pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 822d6d8  ARROW-13172: [Java] Make TYPE_WIDTH publicly accessible
822d6d8 is described below

commit 822d6d8593999a937ccb06d6c89acf44bea2dc54
Author: Eduard Tudenhoefner <et...@gmail.com>
AuthorDate: Mon Aug 9 21:32:32 2021 -0700

    ARROW-13172: [Java] Make TYPE_WIDTH publicly accessible
    
    Some Vector class were already making `TYPE_WIDTH` publicly accessible.
    This PR just makes sure that this is done across all Vector classes.
    
    Closes #10600 from nastra/ARROW-13172
    
    Authored-by: Eduard Tudenhoefner <et...@gmail.com>
    Signed-off-by: Micah Kornfield <em...@gmail.com>
---
 java/vector/src/main/java/org/apache/arrow/vector/DateDayVector.java    | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/DateMilliVector.java  | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/DurationVector.java   | 2 +-
 .../src/main/java/org/apache/arrow/vector/IntervalYearVector.java       | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/TimeMicroVector.java  | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/TimeMilliVector.java  | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/TimeNanoVector.java   | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/TimeSecVector.java    | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/TimeStampVector.java  | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/UInt1Vector.java      | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/UInt2Vector.java      | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/UInt4Vector.java      | 2 +-
 java/vector/src/main/java/org/apache/arrow/vector/UInt8Vector.java      | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/java/vector/src/main/java/org/apache/arrow/vector/DateDayVector.java b/java/vector/src/main/java/org/apache/arrow/vector/DateDayVector.java
index e849a85..3e88268 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/DateDayVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/DateDayVector.java
@@ -37,7 +37,7 @@ import org.apache.arrow.vector.util.TransferPair;
  */
 public final class DateDayVector extends BaseFixedWidthVector {
 
-  private static final byte TYPE_WIDTH = 4;
+  public static final byte TYPE_WIDTH = 4;
   private final FieldReader reader;
 
   /**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/DateMilliVector.java b/java/vector/src/main/java/org/apache/arrow/vector/DateMilliVector.java
index 80f2156..73738d7 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/DateMilliVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/DateMilliVector.java
@@ -39,7 +39,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * maintained to track which elements in the vector are null.
  */
 public final class DateMilliVector extends BaseFixedWidthVector {
-  private static final byte TYPE_WIDTH = 8;
+  public static final byte TYPE_WIDTH = 8;
   private final FieldReader reader;
 
   /**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/DurationVector.java b/java/vector/src/main/java/org/apache/arrow/vector/DurationVector.java
index 9f65c56..9671b34 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/DurationVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/DurationVector.java
@@ -42,7 +42,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * vector are null.
  */
 public final class DurationVector extends BaseFixedWidthVector {
-  private static final byte TYPE_WIDTH = 8;
+  public static final byte TYPE_WIDTH = 8;
   private final FieldReader reader;
 
   private final TimeUnit unit;
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/IntervalYearVector.java b/java/vector/src/main/java/org/apache/arrow/vector/IntervalYearVector.java
index c2eb8cf..7ddfe6b 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/IntervalYearVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/IntervalYearVector.java
@@ -38,7 +38,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * (bit vector) is maintained to track which elements in the vector are null.
  */
 public final class IntervalYearVector extends BaseFixedWidthVector {
-  private static final byte TYPE_WIDTH = 4;
+  public static final byte TYPE_WIDTH = 4;
   private final FieldReader reader;
 
   /**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/TimeMicroVector.java b/java/vector/src/main/java/org/apache/arrow/vector/TimeMicroVector.java
index 7923612..cf12885 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/TimeMicroVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/TimeMicroVector.java
@@ -37,7 +37,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * vector are null.
  */
 public final class TimeMicroVector extends BaseFixedWidthVector {
-  private static final byte TYPE_WIDTH = 8;
+  public static final byte TYPE_WIDTH = 8;
   private final FieldReader reader;
 
   /**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/TimeMilliVector.java b/java/vector/src/main/java/org/apache/arrow/vector/TimeMilliVector.java
index d6c60b0..b96990b 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/TimeMilliVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/TimeMilliVector.java
@@ -39,7 +39,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * (bit vector) is maintained to track which elements in the vector are null.
  */
 public final class TimeMilliVector extends BaseFixedWidthVector {
-  private static final byte TYPE_WIDTH = 4;
+  public static final byte TYPE_WIDTH = 4;
   private final FieldReader reader;
 
   /**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/TimeNanoVector.java b/java/vector/src/main/java/org/apache/arrow/vector/TimeNanoVector.java
index ea8498d..bc78a02 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/TimeNanoVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/TimeNanoVector.java
@@ -36,7 +36,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * (bit vector) is maintained to track which elements in the vector are null.
  */
 public final class TimeNanoVector extends BaseFixedWidthVector {
-  private static final byte TYPE_WIDTH = 8;
+  public static final byte TYPE_WIDTH = 8;
   private final FieldReader reader;
 
   /**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/TimeSecVector.java b/java/vector/src/main/java/org/apache/arrow/vector/TimeSecVector.java
index c867b4f..29b7381 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/TimeSecVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/TimeSecVector.java
@@ -36,7 +36,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * maintained to track which elements in the vector are null.
  */
 public final class TimeSecVector extends BaseFixedWidthVector {
-  private static final byte TYPE_WIDTH = 4;
+  public static final byte TYPE_WIDTH = 4;
   private final FieldReader reader;
 
   /**
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/TimeStampVector.java b/java/vector/src/main/java/org/apache/arrow/vector/TimeStampVector.java
index 7f770fa..d85a793 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/TimeStampVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/TimeStampVector.java
@@ -31,7 +31,7 @@ import org.apache.arrow.vector.util.TransferPair;
  * maintained to track which elements in the vector are null.
  */
 public abstract class TimeStampVector extends BaseFixedWidthVector {
-  protected static final byte TYPE_WIDTH = 8;
+  public static final byte TYPE_WIDTH = 8;
 
   /**
    * Instantiate a TimeStampVector. This doesn't allocate any memory for
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/UInt1Vector.java b/java/vector/src/main/java/org/apache/arrow/vector/UInt1Vector.java
index 4a2e5b1..b735f5f 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/UInt1Vector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/UInt1Vector.java
@@ -46,7 +46,7 @@ public final class UInt1Vector extends BaseFixedWidthVector implements BaseIntVe
    */
   public static final byte MAX_UINT1 = (byte) 0XFF;
 
-  private static final byte TYPE_WIDTH = 1;
+  public static final byte TYPE_WIDTH = 1;
   private final FieldReader reader;
 
   public UInt1Vector(String name, BufferAllocator allocator) {
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/UInt2Vector.java b/java/vector/src/main/java/org/apache/arrow/vector/UInt2Vector.java
index 660194b..917700e 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/UInt2Vector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/UInt2Vector.java
@@ -42,7 +42,7 @@ public final class UInt2Vector extends BaseFixedWidthVector implements BaseIntVe
    */
   public static final char MAX_UINT2 = (char) 0XFFFF;
 
-  private static final byte TYPE_WIDTH = 2;
+  public static final byte TYPE_WIDTH = 2;
   private final FieldReader reader;
 
   public UInt2Vector(String name, BufferAllocator allocator) {
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/UInt4Vector.java b/java/vector/src/main/java/org/apache/arrow/vector/UInt4Vector.java
index 8166dfd..c5045e6 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/UInt4Vector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/UInt4Vector.java
@@ -47,7 +47,7 @@ public final class UInt4Vector extends BaseFixedWidthVector implements BaseIntVe
    */
   public static final int MAX_UINT4 = 0XFFFFFFFF;
 
-  private static final byte TYPE_WIDTH = 4;
+  public static final byte TYPE_WIDTH = 4;
   private final FieldReader reader;
 
   public UInt4Vector(String name, BufferAllocator allocator) {
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/UInt8Vector.java b/java/vector/src/main/java/org/apache/arrow/vector/UInt8Vector.java
index 48f8c50..3aa4451 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/UInt8Vector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/UInt8Vector.java
@@ -44,7 +44,7 @@ public final class UInt8Vector extends BaseFixedWidthVector implements BaseIntVe
    */
   public static final long MAX_UINT8 = 0XFFFFFFFFFFFFFFFFL;
 
-  private static final byte TYPE_WIDTH = 8;
+  public static final byte TYPE_WIDTH = 8;
   private final FieldReader reader;
 
   public UInt8Vector(String name, BufferAllocator allocator) {