You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/04 09:15:07 UTC
[GitHub] [flink] zentol opened a new pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
zentol opened a new pull request #17410:
URL: https://github.com/apache/flink/pull/17410
We now copy the rpc-akka jar in package phase. This allows developers to run `mvn clean compile/test` (and anything in-between) as we no longer require the jar to be present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-937564663
Hi @zentol, I still have some doubts that after changing to the `package` phase , the `mvn clean test` will fail when executing in `flink-rpc-akka-loader` folder. Because the fat jar have not copied, but the testing of `AkkaRpcSystemLoaderTest` rely on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17410:
URL: https://github.com/apache/flink/pull/17410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-937564663
Hi @zentol, I still have some doubts that after changing to the `package` phase , the `mvn clean test` will fail when executing in `flink-rpc-akka-loader` folder. Because the fat jar have not copied, but the testing of `AkkaRpcSystemLoaderTest` rely on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-934572798
Hi @zentol , please take a look on this ticket [FLINK-24455](https://issues.apache.org/jira/browse/FLINK-24455), I think it should be solved before merging this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-933317819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6f093536dfb23f1a6b1702d2325c41fb07b07884",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24736",
"triggerID" : "6f093536dfb23f1a6b1702d2325c41fb07b07884",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f093536dfb23f1a6b1702d2325c41fb07b07884 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24736)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-933317819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6f093536dfb23f1a6b1702d2325c41fb07b07884",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f093536dfb23f1a6b1702d2325c41fb07b07884",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f093536dfb23f1a6b1702d2325c41fb07b07884 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Aitozi commented on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
Aitozi commented on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-934680980
> Hi @zentol , please take a look on this ticket [FLINK-24455](https://issues.apache.org/jira/browse/FLINK-24455), I think it should be solved before merging this PR
It turns out the error reported is unrelated, +1 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-933317819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6f093536dfb23f1a6b1702d2325c41fb07b07884",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24736",
"triggerID" : "6f093536dfb23f1a6b1702d2325c41fb07b07884",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f093536dfb23f1a6b1702d2325c41fb07b07884 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24736)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17410: [FLINK-24445][build] Copy rpc-akka jar in package phase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17410:
URL: https://github.com/apache/flink/pull/17410#issuecomment-933301624
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6f093536dfb23f1a6b1702d2325c41fb07b07884 (Mon Oct 04 09:19:40 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org