[jira] [Commented] (SYNCOPE-45) Make all delete operations consistent in the REST API

["Colm O hEigeartaigh (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNCOPE-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246309#comment-13246309 ] 

Colm O hEigeartaigh commented on SYNCOPE-45:
--------------------------------------------


I've run into a problem with this task for a couple of the controllers, where the object being returned is a subclass of some type. For example, the deleted object being returned from the PolicyController is an instance of PolicyTO such as PasswordPolicyTO.

Switching to GET for the above requires that the user knows what instance of PolicyTO is being returned, or else an error will occur. Should I retain the HTTP DELETE verbs for these classes? Or is it reasonable to expect that the user knows what subclass to use?

Colm.
                
> Make all delete operations consistent in the REST API
> -----------------------------------------------------
>
>                 Key: SYNCOPE-45
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-45
>             Project: Syncope
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>
> There is a lack of consistency in how the REST controllers handle deletion. For example, RoleController.delete() does not return the deleted RoleTO object, unlike the corresponding method in UserController. It also uses the HTTP delete verb instead of get as per the UserController. I suggest there should be consistent behaviour for delete across the controllers, in other words all delete functionality should use HTTP GET and return the deleted object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira