You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2021/12/13 16:24:37 UTC
[ofbiz-framework] branch trunk updated: Improved: Address SpotBugs issue by avoiding nulls in parameter matches for JMockit Expectations (OFBIZ-11456)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 3b99529 Improved: Address SpotBugs issue by avoiding nulls in parameter matches for JMockit Expectations (OFBIZ-11456)
3b99529 is described below
commit 3b99529c0d203d509350b76e4a245325a7970dea
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Mon Dec 13 17:24:02 2021 +0100
Improved: Address SpotBugs issue by avoiding nulls in parameter matches for JMockit Expectations (OFBIZ-11456)
Same than https://github.com/apache/ofbiz-framework/pull/411
Thanks: Daniel
---
.../org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java b/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java
index 3e77069..9951a29 100644
--- a/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java
+++ b/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java
@@ -844,8 +844,7 @@ public class MacroFormRendererTest {
{
modelForm.getPaginateTarget(withNotNull());
result = targetService;
- // FIXME SpotBugs reports: Argument 1 is definitely null but must not be null
- requestHandler.makeLink(null, null, withSubstring(qbeString));
+ requestHandler.makeLink(withNotNull(), withNotNull(), withSubstring(qbeString));
result = linkFromQbeString;
}
};