You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/06/20 12:57:39 UTC

[GitHub] [skywalking-java] hutaishi commented on a diff in pull request #215: [Bug #9250]shenyu plugin fix IgnoredTracerContext traceId NPE

hutaishi commented on code in PR #215:
URL: https://github.com/apache/skywalking-java/pull/215#discussion_r901633933


##########
CHANGES.md:
##########
@@ -4,7 +4,7 @@ Release Notes.
 
 8.12.0
 ------------------
-
+* Fix `Shenyu plugin` IgnoredTracerContext traceId NPE(Use with the apm-trace-ignore-plugin plugin will trigger)

Review Comment:
   > IgnoredTracerContext could be activated in many cases, such as ignore-plugin, sampling policy activated, and agent disconnected with the OAP server.
   
   Understood, not enough consideration at the time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org