Re: [I] Fix flaky FlinkCompaction integration test [hudi]

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on issue #14886:
URL: https://github.com/apache/hudi/issues/14886#issuecomment-4795276748

   This appears to be addressed in master. The `ITTestHoodieFlinkCompactor` tests (`testHoodieFlinkCompactor`, `testHoodieFlinkCompactorService`, etc.) are present and not `@Disabled` in `hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/compact/ITTestHoodieFlinkCompactor.java`.
   
   The most recent flakiness fix landed in commit [`321b4299b2bd`](https://github.com/apache/hudi/commit/321b4299b2bd2eb3fa55340a4cfa382b4a1368c4) (PR #17677, "test: Fix flaky test ITTestHoodieFlinkCompactor#testHoodieFlinkCompactorService"), which replaced a fixed `TimeUnit.SECONDS.sleep(10)` with a `TestUtils.waitUntil(...)` polling loop bounded by a 20s timeout, asserting the compaction commit actually completes. This is the standard fix for this class of timing flake.
   
   If no further flakes have been observed in CI on these tests, this issue can likely be closed. Reopen if intermittent failures resurface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org