You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/18 04:53:09 UTC

[GitHub] [incubator-inlong] yunqingmoswu opened a new pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

yunqingmoswu opened a new pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217


   ### Title Name: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id
   
   Fixes #3208 
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] yunqingmoswu commented on a change in pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on a change in pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217#discussion_r829698527



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;
+
+    @ApiModelProperty(value = "Inlong group id list")
+    private List<String> inlongGroupIds;

Review comment:
       done

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow merged pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] yunqingmoswu commented on a change in pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on a change in pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217#discussion_r829698527



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;
+
+    @ApiModelProperty(value = "Inlong group id list")
+    private List<String> inlongGroupIds;

Review comment:
       done

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a change in pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217#discussion_r829695528



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;

Review comment:
       It is recommended to modify it to `nameList`.

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;
+
+    @ApiModelProperty(value = "Inlong group id list")
+    private List<String> inlongGroupIds;

Review comment:
       It is recommended to modify it to `groupIdList`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a change in pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217#discussion_r829695528



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;

Review comment:
       It is recommended to modify it to `nameList`.

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/group/InlongGroupPageRequest.java
##########
@@ -34,6 +36,12 @@
     @ApiModelProperty(value = "Keywords")
     private String keyWord;
 
+    @ApiModelProperty(value = "Inlong group name list")
+    private List<String> names;
+
+    @ApiModelProperty(value = "Inlong group id list")
+    private List<String> inlongGroupIds;

Review comment:
       It is recommended to modify it to `groupIdList`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow merged pull request #3217: [INLONG-3208][Manager] Support batch query by inlong group name and inlong group id

Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3217:
URL: https://github.com/apache/incubator-inlong/pull/3217


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org