You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by davinash <gi...@git.apache.org> on 2016/12/14 05:35:02 UTC
[GitHub] geode pull request #315: GEODE-1995: Removed ReliableMessageQueue, ReliableM...
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/315
GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory\u2026
\u2026, ReliableMessageQueueFactoryImpl and
it's usage in the code from GemfireCacheImpl and DistributedRegion.
CC @dschneider-pivotal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-1995
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit 7fdf95086d1f31e5520c449c254a9a07d813fbe8
Author: adongre <ad...@apache.org>
Date: 2016-12-13T07:20:31Z
GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQueueFactory, ReliableMessageQueueFactoryImpl and
it's usage in the code from GemfireCacheImpl and DistributedRegion.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/315
@dschneider-pivotal what's next for this PR? Is it good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
Thanks @dschneider-pivotal for review, I will make these changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
Is this PR looking good now ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
@metatype , @dschneider-pivotal Please let me know if this is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #315: GEODE-1995: Removed ReliableMessageQueue, ReliableM...
Posted by davinash <gi...@git.apache.org>.
Github user davinash closed the pull request at:
https://github.com/apache/geode/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/315
I think you should continue to remove code that was only used by ReliableMessageQueueFactoryImpl. This included the following:
1. LocalizedStrings that this class used.
2. ReliableDistributionData: the methods on this interface were only called by ReliableMessageQueueFactoryImpl. So this interface should be removed and all the implementations of this interface (lots of *Message classes).
3. DistributedRegion.sendQueue method: it is only called by ReliableMessageQueueFactoryImpl.
Getting rid of that method lets you delete SendQueueOperation which gets rid of SendQueueMessage which lets you get rid of SEND_QUEUE_MESSAGE (you will need to also remove some references for this message from DSFIDFactory).
It would be best to remove all this stuff with one checkin. Just just look over each class you remove and see what it references that will no longer be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
Please review this PR, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/315
All test passed. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---