[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #18045: parse aggregationProjectionSegment with columnSegment

[GitBox <gi...@apache.org>]

tuichenchuxin commented on code in PR #18045:
URL: https://github.com/apache/shardingsphere/pull/18045#discussion_r884501273


##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/item/AggregationProjectionSegment.java:
##########
@@ -40,6 +40,9 @@ public class AggregationProjectionSegment implements ProjectionSegment, AliasAva
     
     private final String innerExpression;
     
+    @Setter
+    private ExpressionSegment expression;

Review Comment:
   maybe have multi expression.
   ```
   private final Collection<ExpressionSegment> parameters = new LinkedList<>();
   ```
   This maybe better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org