You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/05/19 09:59:59 UTC

[GitHub] [iotdb] zhanglingzhe0820 opened a new pull request #3233: Update TSDB-comparison doc and `Merge` command doc

zhanglingzhe0820 opened a new pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #3233: Update TSDB-comparison doc and `Merge` command doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233#discussion_r635771201



##########
File path: docs/UserGuide/IoTDB-SQL-Language/Maintenance-Command.md
##########
@@ -31,10 +31,10 @@ IoTDB> FLUSH root.sg1,root.sg2
 
 ### MERGE
 
-Merge sequence and unsequence data. Currently IoTDB supports the following two types of SQL to manually trigger the merge process of data files:
+Execute Level Compaction and unsequence Compaction task. Currently IoTDB supports the following two types of SQL to manually trigger the compaction process of data files:
 
-* `MERGE` Only rewrite overlapped Chunks, the merge speed is quick, while there will be redundant data on the disk eventually.
-* `FULL MERGE` Rewrite all data in overlapped files, the merge speed is slow, but there will be no redundant data on the disk eventually.
+* `MERGE` Execute Level Compaction first and then execute unsequence Compaction. In unsequence Compaction, this command will only rewrite overlapped Chunks, the merge speed is quick, while there will be redundant data on the disk eventually.

Review comment:
       ```suggestion
   * `MERGE` Execute the level compaction first and then execute the unsequence compaction. In unsequence compaction process, this command is executed very fast by rewriting the overlapped Chunks only, while there is some redundant data on the disk eventually.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #3233: Update TSDB-comparison doc and `Merge` command doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233#discussion_r635772657



##########
File path: docs/UserGuide/IoTDB-SQL-Language/Maintenance-Command.md
##########
@@ -31,10 +31,10 @@ IoTDB> FLUSH root.sg1,root.sg2
 
 ### MERGE
 
-Merge sequence and unsequence data. Currently IoTDB supports the following two types of SQL to manually trigger the merge process of data files:
+Execute Level Compaction and unsequence Compaction task. Currently IoTDB supports the following two types of SQL to manually trigger the compaction process of data files:

Review comment:
       Add Chinese doc?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #3233: Update TSDB-comparison doc and `Merge` command doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233#discussion_r637772407



##########
File path: docs/UserGuide/Comparison/TSDB-Comparison.md
##########
@@ -331,14 +335,22 @@ The write throughput (points/second) is:
 ![Aggregation query](https://user-images.githubusercontent.com/24886743/106251336-cf03c000-624f-11eb-8395-de5e349f47b5.png)
 <center>Figure 6. Aggregation query time cost(ms) IoTDB v0.11.1</center>

Review comment:
       Where is the Figure 5?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #3233: Update TSDB-comparison doc and `Merge` command doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233#discussion_r635772554



##########
File path: docs/UserGuide/IoTDB-SQL-Language/Maintenance-Command.md
##########
@@ -31,10 +31,10 @@ IoTDB> FLUSH root.sg1,root.sg2
 
 ### MERGE
 
-Merge sequence and unsequence data. Currently IoTDB supports the following two types of SQL to manually trigger the merge process of data files:
+Execute Level Compaction and unsequence Compaction task. Currently IoTDB supports the following two types of SQL to manually trigger the compaction process of data files:
 
-* `MERGE` Only rewrite overlapped Chunks, the merge speed is quick, while there will be redundant data on the disk eventually.
-* `FULL MERGE` Rewrite all data in overlapped files, the merge speed is slow, but there will be no redundant data on the disk eventually.
+* `MERGE` Execute Level Compaction first and then execute unsequence Compaction. In unsequence Compaction, this command will only rewrite overlapped Chunks, the merge speed is quick, while there will be redundant data on the disk eventually.
+* `FULL MERGE` Execute Level Compaction first and then execute unsequence Compaction. In unsequence Compaction, this command will rewrite all data in overlapped files, the merge speed is slow, but there will be no redundant data on the disk eventually.

Review comment:
       ```suggestion
   * `FULL MERGE` Execute the level compaction first and then execute the unsequence compaction. In unsequence compaction process, this command is executed slow due to it takes more time to rewrite all data in overlapped files. However, there won't be any redundant data on the disk eventually.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #3233: Update TSDB-comparison doc and `Merge` command doc

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #3233: Update TSDB-comparison doc and `Merge` command doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233#discussion_r635768987



##########
File path: docs/UserGuide/IoTDB-SQL-Language/Maintenance-Command.md
##########
@@ -31,10 +31,10 @@ IoTDB> FLUSH root.sg1,root.sg2
 
 ### MERGE
 
-Merge sequence and unsequence data. Currently IoTDB supports the following two types of SQL to manually trigger the merge process of data files:
+Execute Level Compaction and unsequence Compaction task. Currently IoTDB supports the following two types of SQL to manually trigger the compaction process of data files:

Review comment:
       ```suggestion
   Execute the level compaction and the unsequence compaction task. Currently IoTDB supports the following two types of SQL to manually trigger the compaction process of data files:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #3233: Update TSDB-comparison doc and `Merge` command doc

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3233:
URL: https://github.com/apache/iotdb/pull/3233#discussion_r635767814



##########
File path: docs/UserGuide/Comparison/TSDB-Comparison.md
##########
@@ -293,24 +293,28 @@ We test the performance of writing from two aspects: *batch size* and *client nu
 10 clients read data concurrently. The number of storage group is 10. There are 10 devices and each device has 10 measurements (i.e.,, 100 time series total).
 The data type is *double*, encoding type is *GORILLA*
 
+* Compression:
+
+We use several famous dataset as test. We compare TsFile(the file format of IoTDB) with Parquet, ORC and Csv by their file size after the same dataset is written.

Review comment:
       ```suggestion
   We test and compare file sizes of TsFile(the file format of IoTDB) and some others famous dataset formats, which are Parquet, ORC and Csv, after the same datasets are written.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org