You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "Nick Allen (JIRA)" <ji...@apache.org> on 2017/03/01 13:41:45 UTC

[jira] [Commented] (METRON-747) Blanket Reformat of code based on checkstyle configs

    [ https://issues.apache.org/jira/browse/METRON-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890177#comment-15890177 ] 

Nick Allen commented on METRON-747:
-----------------------------------

I have seen in the generated code from ANTRL specific comments that seem to be intended to solve this problem.  For example, in org.apache.metron.common.stellar.generated.StellarLexer there is a comment on line 4 "//CHECKSTYLE:OFF".   

> Blanket Reformat of code based on checkstyle configs
> ----------------------------------------------------
>
>                 Key: METRON-747
>                 URL: https://issues.apache.org/jira/browse/METRON-747
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Justin Leet
>            Priority: Minor
>
> Once METRON-746 is done, we should perform a blanket reformat of our code per discussion on the dev list.  At this point we should start enforcing our code via checkstyle (so make sure the appropriate code styling is set to error).
> We might need to be careful about autogenerated code here (otherwise we might start breaking builds on things we don't care about).  I'm unsure if you can whitelist specific files or dirs in checkstyle or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)