[GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...

[zuyu <gi...@git.apache.org>]

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66543912
  
    --- Diff: storage/InsertDestination.cpp ---
    @@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const CatalogRelationSchema &relation,
                                          const StorageBlockLayout *layout,
                                          StorageManager *storage_manager,
                                          const std::size_t relational_op_index,
    +                                     const std::size_t query_id,
    --- End diff --
    
    I suggest to move `query_id` before `relational_op_index` based on a top-down relations of things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---