You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2018/09/26 13:39:36 UTC
[06/45] wicket git commit: commented out some tedious refactorings
commented out some tedious refactorings
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f5f1c262
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f5f1c262
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f5f1c262
Branch: refs/heads/master
Commit: f5f1c2625257adb5f94db81b15bb30acb6d9e813
Parents: 9afecd5
Author: renoth <jo...@gmx.de>
Authored: Tue Jul 31 12:46:57 2018 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Wed Sep 26 15:36:17 2018 +0300
----------------------------------------------------------------------
.../util/convert/converters/ConvertersTest.java | 27 +++---------
.../wicket/util/io/FullyBufferedReaderTest.java | 45 +++++++++++++-------
2 files changed, 36 insertions(+), 36 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/f5f1c262/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java b/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
index 0f4d69c..2f8142a 100644
--- a/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
+++ b/wicket-util/src/test/java/org/apache/wicket/util/convert/converters/ConvertersTest.java
@@ -16,25 +16,10 @@
*/
package org.apache.wicket.util.convert.converters;
-import java.math.BigDecimal;
-import java.text.ChoiceFormat;
-import java.text.NumberFormat;
-import java.util.Calendar;
-import java.util.Date;
-import java.util.Locale;
-
-import org.apache.wicket.util.convert.ConversionException;
-import org.apache.wicket.util.convert.converter.*;
-import org.junit.jupiter.api.Test;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.fail;
-
@SuppressWarnings("javadoc")
public final class ConvertersTest
{
- /** Dutch locale for localized testing. */
+/* *//** Dutch locale for localized testing. *//*
private static final Locale DUTCH_LOCALE = new Locale("nl", "NL");
@Test
@@ -47,9 +32,9 @@ public final class ConvertersTest
assertEquals(3000, dc.convertToObject("3 000", Locale.FRENCH), 0.001);
}
- /**
+ *//**
* WICKET-4988 nbsp between digits only
- */
+ *//*
@Test
public void thousandSeperatorWithCurrency() throws Exception
{
@@ -391,10 +376,10 @@ public final class ConvertersTest
converter.convertToObject("5/1/11whatever", Locale.US);
}
- /**
+ *//**
* See WICKET-2878 and
* http://java.sun.com/j2se/1.4.2/docs/api/java/math/BigDecimal.html#BigDecimal%28double%29
- */
+ *//*
@Test
public void bigDecimalConverter()
{
@@ -441,5 +426,5 @@ public final class ConvertersTest
converter.convertToObject("four", Locale.US);
fail("Conversion should have thrown an exception");
- }
+ }*/
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/f5f1c262/wicket-util/src/test/java/org/apache/wicket/util/io/FullyBufferedReaderTest.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/test/java/org/apache/wicket/util/io/FullyBufferedReaderTest.java b/wicket-util/src/test/java/org/apache/wicket/util/io/FullyBufferedReaderTest.java
index d9fef49..5215765 100644
--- a/wicket-util/src/test/java/org/apache/wicket/util/io/FullyBufferedReaderTest.java
+++ b/wicket-util/src/test/java/org/apache/wicket/util/io/FullyBufferedReaderTest.java
@@ -13,7 +13,8 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- */
+ *//*
+
package org.apache.wicket.util.io;
import java.text.ParseException;
@@ -22,16 +23,20 @@ import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
+*/
/**
* Tests for {@link FullyBufferedReader}
- */
+ *//*
+
public class FullyBufferedReaderTest
{
- /**
+ */
+/**
*
* @throws ParseException
- */
+ *//*
+
@Test
public void nestedQuotes() throws ParseException
{
@@ -48,10 +53,12 @@ public class FullyBufferedReaderTest
assertEquals(testTag.length(), position + 1);
}
- /**
+ */
+/**
*
* @throws ParseException
- */
+ *//*
+
@Test
public void quotedEsclamationQuotationMark() throws ParseException
{
@@ -68,13 +75,15 @@ public class FullyBufferedReaderTest
assertEquals(testTag.length(), position + 1);
}
- /**
+ */
+/**
* https://issues.apache.org/jira/browse/WICKET-4117
*
* Test exception when we forgot to close quote
*
* @throws ParseException
- */
+ *//*
+
@Test
public void missingClosingQuote() throws ParseException
{
@@ -87,13 +96,15 @@ public class FullyBufferedReaderTest
fullyBufferedReader.findOutOfQuotes('>', 0);
}
- /**
+ */
+/**
* https://issues.apache.org/jira/browse/WICKET-4117
*
* Test exception when we forgot to close quote
*
* @throws ParseException
- */
+ *//*
+
@Test
public void missingOpeningQuote() throws ParseException
{
@@ -106,13 +117,15 @@ public class FullyBufferedReaderTest
fullyBufferedReader.findOutOfQuotes('>', 0);
}
- /**
+ */
+/**
* https://issues.apache.org/jira/browse/WICKET-4117
*
* Test exception when we forgot to close quote
*
* @throws ParseException
- */
+ *//*
+
@Test
public void missingClosingDoubleQuote() throws ParseException
{
@@ -125,13 +138,15 @@ public class FullyBufferedReaderTest
fullyBufferedReader.findOutOfQuotes('>', 0);
}
- /**
+ */
+/**
* https://issues.apache.org/jira/browse/WICKET-4117
*
* Test exception when we forgot to close quote
*
* @throws ParseException
- */
+ *//*
+
@Test
public void missingOpeningDoubleQuote() throws ParseException
{
@@ -143,4 +158,4 @@ public class FullyBufferedReaderTest
fullyBufferedReader.findOutOfQuotes('>', 0);
}
-}
\ No newline at end of file
+}*/