You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/28 01:36:16 UTC

[GitHub] [arrow] nealrichardson commented on a diff in pull request #13441: ARROW-16912: [R][CI] Fix nightly centos package without GCS

nealrichardson commented on code in PR #13441:
URL: https://github.com/apache/arrow/pull/13441#discussion_r907940234


##########
docker-compose.yml:
##########
@@ -410,9 +410,9 @@ services:
       ARROW_MIMALLOC: "ON"
     command: >
       /bin/bash -c "
-        if grep -q -i -e 'centos.* 7' /etc/os-release; then export ARROW_S3=OFF ARROW_MIMALLOC=OFF; fi &&
+        if grep -q -i -e 'centos.* 7' /etc/os-release; then export ARROW_S3=OFF ARROW_GCS=OFF ARROW_MIMALLOC=OFF; fi &&

Review Comment:
   IIUC the intent is that these are only set on centos 7, and you can't conditionally set env vars in `environment:`. Though the setup appears to have baked in centos 7 from where it inherits, so maybe that's not a concern?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org