You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/05/01 15:06:59 UTC

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3364: improve code and docs related to operation id column

dlmarion commented on code in PR #3364:
URL: https://github.com/apache/accumulo/pull/3364#discussion_r1181636734


##########
server/base/src/main/java/org/apache/accumulo/server/constraints/MetadataConstraints.java:
##########
@@ -224,8 +225,15 @@ public List<Short> check(Environment env, Mutation mutation) {
         try {
           TabletHostingGoalUtil.fromValue(new Value(columnUpdate.getValue()));
         } catch (IllegalArgumentException e) {
-          violations = addViolation(violations, 4);
+          violations = addViolation(violations, 10);
         }
+      } else if (ServerColumnFamily.OPID_COLUMN.equals(columnFamily, columnQualifier)) {

Review Comment:
   I think you need to update the check on line 207 that checks that the Value is not empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org