You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Nick Burch <ni...@apache.org> on 2013/08/23 20:45:03 UTC
Broken test on head
Hi All
Is anyone else seeing a broken test on head?
[junit] Running org.apache.poi.hssf.eventusermodel.TestEventWorkbookBuilder
[junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.033 sec
Testcase: testFormulas took 0.022 sec
FAILED
expected:<SUM([Sh3]!A1:A4)> but was:<SUM(['Sh3']!A1:A4)>
junit.framework.ComparisonFailure: expected:<SUM([Sh3]!A1:A4)> but
was:<SUM(['Sh3']!A1:A4)>
at
org.apache.poi.hssf.eventusermodel.TestEventWorkbookBuilder.testFormulas(TestEventWorkbookBuilder.java:138)
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: Broken test on head
Posted by Dominik Stadler <do...@gmx.at>.
Should be fixed again now.
Cheers... Dominik.
On Sat, Aug 24, 2013 at 12:10 PM, Dominik Stadler <do...@gmx.at>wrote:
> Problem is here:
>
> - colRef = colChar + colRef;
> + colRef.append(colChar);
>
> the result in the new version is different as previously it was sort of a
> "prepend", not an append...
>
> Dominik.
>
>
> On Sat, Aug 24, 2013 at 12:06 PM, Dominik Stadler <do...@gmx.at>wrote:
>
>> This is a classic use-case for "git bisect": Just kick it off and let it
>> work out which commit broke the test:
>>
>> Total time: 3 minutes 30 seconds
>> fd90a2319f81234730f311c4a3053b302343b54f is the first bad commit
>> commit fd90a2319f81234730f311c4a3053b302343b54f
>> Author: nick <ni...@13f79535-47bb-0310-9956-ffa450edef68>
>> Date: Fri Aug 23 18:30:01 2013 +0000
>>
>> Inspired by github pull-6, use a StringBuilder for quicker string
>> appending
>>
>> git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@151696913f79535-47bb-0310-9956-ffa450edef68
>>
>> :040000 040000 0952c6318a7f2d8315e7e165b72b94cc8ca3f156
>> 09e64c6f5b1e5fbd017ea4e2937f89a1bc138398 M src
>> bisect run success
>>
>>
>>
>>
>> On Fri, Aug 23, 2013 at 8:45 PM, Nick Burch <ni...@apache.org> wrote:
>>
>>> Hi All
>>>
>>> Is anyone else seeing a broken test on head?
>>>
>>> [junit] Running org.apache.poi.hssf.**eventusermodel.**
>>> TestEventWorkbookBuilder
>>> [junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.033 sec
>>>
>>> Testcase: testFormulas took 0.022 sec
>>> FAILED
>>> expected:<SUM([Sh3]!A1:A4)> but was:<SUM(['Sh3']!A1:A4)>
>>> junit.framework.**ComparisonFailure: expected:<SUM([Sh3]!A1:A4)> but
>>> was:<SUM(['Sh3']!A1:A4)>
>>> at org.apache.poi.hssf.**eventusermodel.**
>>> TestEventWorkbookBuilder.**testFormulas(**TestEventWorkbookBuilder.java:
>>> **138)
>>>
>>>
>>>
>>> Nick
>>>
>>> ------------------------------**------------------------------**
>>> ---------
>>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>>> For additional commands, e-mail: dev-help@poi.apache.org
>>>
>>>
>>
>
Re: Broken test on head
Posted by Dominik Stadler <do...@gmx.at>.
Problem is here:
- colRef = colChar + colRef;
+ colRef.append(colChar);
the result in the new version is different as previously it was sort of a
"prepend", not an append...
Dominik.
On Sat, Aug 24, 2013 at 12:06 PM, Dominik Stadler <do...@gmx.at>wrote:
> This is a classic use-case for "git bisect": Just kick it off and let it
> work out which commit broke the test:
>
> Total time: 3 minutes 30 seconds
> fd90a2319f81234730f311c4a3053b302343b54f is the first bad commit
> commit fd90a2319f81234730f311c4a3053b302343b54f
> Author: nick <ni...@13f79535-47bb-0310-9956-ffa450edef68>
> Date: Fri Aug 23 18:30:01 2013 +0000
>
> Inspired by github pull-6, use a StringBuilder for quicker string
> appending
>
> git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@151696913f79535-47bb-0310-9956-ffa450edef68
>
> :040000 040000 0952c6318a7f2d8315e7e165b72b94cc8ca3f156
> 09e64c6f5b1e5fbd017ea4e2937f89a1bc138398 M src
> bisect run success
>
>
>
>
> On Fri, Aug 23, 2013 at 8:45 PM, Nick Burch <ni...@apache.org> wrote:
>
>> Hi All
>>
>> Is anyone else seeing a broken test on head?
>>
>> [junit] Running org.apache.poi.hssf.**eventusermodel.**
>> TestEventWorkbookBuilder
>> [junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.033 sec
>>
>> Testcase: testFormulas took 0.022 sec
>> FAILED
>> expected:<SUM([Sh3]!A1:A4)> but was:<SUM(['Sh3']!A1:A4)>
>> junit.framework.**ComparisonFailure: expected:<SUM([Sh3]!A1:A4)> but
>> was:<SUM(['Sh3']!A1:A4)>
>> at org.apache.poi.hssf.**eventusermodel.**
>> TestEventWorkbookBuilder.**testFormulas(**TestEventWorkbookBuilder.java:*
>> *138)
>>
>>
>>
>> Nick
>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
>>
>
Re: Broken test on head
Posted by Dominik Stadler <do...@gmx.at>.
This is a classic use-case for "git bisect": Just kick it off and let it
work out which commit broke the test:
Total time: 3 minutes 30 seconds
fd90a2319f81234730f311c4a3053b302343b54f is the first bad commit
commit fd90a2319f81234730f311c4a3053b302343b54f
Author: nick <ni...@13f79535-47bb-0310-9956-ffa450edef68>
Date: Fri Aug 23 18:30:01 2013 +0000
Inspired by github pull-6, use a StringBuilder for quicker string
appending
git-svn-id:
https://svn.apache.org/repos/asf/poi/trunk@151696913f79535-47bb-0310-9956-ffa450edef68
:040000 040000 0952c6318a7f2d8315e7e165b72b94cc8ca3f156
09e64c6f5b1e5fbd017ea4e2937f89a1bc138398 M src
bisect run success
On Fri, Aug 23, 2013 at 8:45 PM, Nick Burch <ni...@apache.org> wrote:
> Hi All
>
> Is anyone else seeing a broken test on head?
>
> [junit] Running org.apache.poi.hssf.**eventusermodel.**
> TestEventWorkbookBuilder
> [junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.033 sec
>
> Testcase: testFormulas took 0.022 sec
> FAILED
> expected:<SUM([Sh3]!A1:A4)> but was:<SUM(['Sh3']!A1:A4)>
> junit.framework.**ComparisonFailure: expected:<SUM([Sh3]!A1:A4)> but
> was:<SUM(['Sh3']!A1:A4)>
> at org.apache.poi.hssf.**eventusermodel.**
> TestEventWorkbookBuilder.**testFormulas(**TestEventWorkbookBuilder.java:**
> 138)
>
>
>
> Nick
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>