You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@curator.apache.org by ra...@apache.org on 2019/09/28 17:47:16 UTC
[curator] branch CURATOR-543-fix-testLockACLs-due-to-ZOOKEEPER-1392
created (now 3083f8d)
This is an automated email from the ASF dual-hosted git repository.
randgalt pushed a change to branch CURATOR-543-fix-testLockACLs-due-to-ZOOKEEPER-1392
in repository https://gitbox.apache.org/repos/asf/curator.git.
at 3083f8d CURATOR-543
This branch includes the following new commits:
new 3083f8d CURATOR-543
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[curator] 01/01: CURATOR-543
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
randgalt pushed a commit to branch CURATOR-543-fix-testLockACLs-due-to-ZOOKEEPER-1392
in repository https://gitbox.apache.org/repos/asf/curator.git
commit 3083f8dee9ded3fada94c8c7c29a64b7f991418a
Author: randgalt <ra...@apache.org>
AuthorDate: Sat Sep 28 12:46:35 2019 -0500
CURATOR-543
ZOOKEEPER-1392 broke TestLockACLs. In order to read ACLS you now need READ perm. TestLockACLs.testLockACLs() needs to be updated to reflect this.
---
.../java/org/apache/curator/framework/recipes/locks/TestLockACLs.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/curator-recipes/src/test/java/org/apache/curator/framework/recipes/locks/TestLockACLs.java b/curator-recipes/src/test/java/org/apache/curator/framework/recipes/locks/TestLockACLs.java
index 0fa95cf..3676d6f 100644
--- a/curator-recipes/src/test/java/org/apache/curator/framework/recipes/locks/TestLockACLs.java
+++ b/curator-recipes/src/test/java/org/apache/curator/framework/recipes/locks/TestLockACLs.java
@@ -38,7 +38,7 @@ import java.util.List;
public class TestLockACLs extends BaseClassForTests
{
private static final List<ACL> ACLS1 = Collections.singletonList(new ACL(ZooDefs.Perms.ALL, new Id("ip", "127.0.0.1")));
- private static final List<ACL> ACLS2 = Collections.singletonList(new ACL(ZooDefs.Perms.CREATE, new Id("ip", "127.0.0.1")));
+ private static final List<ACL> ACLS2 = Collections.singletonList(new ACL(ZooDefs.Perms.CREATE | ZooDefs.Perms.READ, new Id("ip", "127.0.0.1")));
private CuratorFramework createClient(ACLProvider provider) throws Exception
{
@@ -86,7 +86,7 @@ public class TestLockACLs extends BaseClassForTests
try
{
client.create().creatingParentsIfNeeded().forPath("/parent/foo");
- Assert.assertEquals(ZooDefs.Perms.CREATE, client.getACL().forPath("/parent").get(0).getPerms());
+ Assert.assertEquals(ZooDefs.Perms.CREATE | ZooDefs.Perms.READ, client.getACL().forPath("/parent").get(0).getPerms());
Assert.assertEquals(ZooDefs.Perms.ALL, client.getACL().forPath("/parent/foo").get(0).getPerms());
}
finally