You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 08:47:52 UTC

[GitHub] [apisix-dashboard] starsz opened a new issue #1119: Bug: fix the sleep in e2e test

starsz opened a new issue #1119:
URL: https://github.com/apache/apisix-dashboard/issues/1119


   # Bug report
   
   ## Describe the bug
   
   A clear and concise description of what the bug is.
   
   I think sleep should be done after the request sent and the response check.
   
   
   ## Additional context
   
   Add any other context about the problem here.
   
   Now, the sleep is after the new req object.
   
   https://github.com/apache/apisix-dashboard/blob/d4792fcf4eea985ea44a76f86e93d5c784d2ae5c/api/test/e2e/base.go#L194-L200
   
   I think it should be put after the body check. So that we can ensure that the `etcd` had stored the content.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz closed issue #1119: Bug: the sleep should be done after the body check in api e2e test

Posted by GitBox <gi...@apache.org>.

starsz closed issue #1119:
URL: https://github.com/apache/apisix-dashboard/issues/1119


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org