You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/26 09:20:08 UTC

[GitHub] [orc] noirello commented on pull request #669: ORC-773: BinaryColumnWriter does not update Bloom filter

noirello commented on pull request #669:
URL: https://github.com/apache/orc/pull/669#issuecomment-808063423


   Oh I see. I didn't check the predicate implementation. I just only saw that the [Java counterpart](https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/writer/BinaryTreeWriter.java#L95) updates the filter, and I thought it could be problematic initialising but not updating it on the C++ side.
   
   But now I checked Trino as another reference, where it seems neither the reader expects Bloom filter for a binary column (just like the implementations here), nor the writer creates Bloom filter for binary statistics.
   
   I guess there aren't many valid use cases for it. Should I close this with the related issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org