You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/10/24 19:22:35 UTC
[GitHub] [solr] warperwolf commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module
warperwolf commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r735159627
##########
File path: solr/test-framework/src/java/org/apache/solr/handler/package.html
##########
@@ -0,0 +1,24 @@
+<!doctype html public "-//w3c//dtd html 4.0 transitional//en">
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<!-- not a package-info.java, because we already defined this package in core/ -->
Review comment:
> We probably want to look at renaming some of the packages for the moved classes, since split packages are going to cause problems down the line anyway. Maybe ok to do this in a follow on issue if it ends up being too much here.
Thanks for the review!
@madrob, @dsmiley: Do you think it would make sense to include something like testfixture in the package name of the test fixture classes we put to the test framework? For example org.apache.solr.testfixture.handler. That way all the fixtures we put into the test framework would be centralized as they would all be subpackages of the org.apache.solr.testfixture and that would also make it easier to relocate them once we fix the problem with gradle vs. test fixtures ( https://issues.apache.org/jira/browse/SOLR-14660?focusedCommentId=17409690&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17409690 ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org