[GitHub] [spark] beliefer commented on a change in pull request #33588: [SPARK-36346][SQL] Support TimestampNTZ type in Orc file source

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #33588:
URL: https://github.com/apache/spark/pull/33588#discussion_r747248780



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala
##########
@@ -194,7 +194,7 @@ class OrcFileFormat extends FileFormat with DataSourceRegister with Serializable
   }
 
   override def supportDataType(dataType: DataType): Boolean = dataType match {
-    case _: AnsiIntervalType => false
+    case _: AnsiIntervalType | _: TimestampNTZType => false

Review comment:
       Because we store TimestampNTZ as timestamp type in ORC, I will revert this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org