You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/03/25 02:33:57 UTC
[GitHub] [avro] thiru-mg opened a new pull request #1154: Reformatted C++ sources to make them consistent
thiru-mg opened a new pull request #1154:
URL: https://github.com/apache/avro/pull/1154
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3051
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: This is a format-only change
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] thiru-mg merged pull request #1154: AVRO-3051: Reformatted C++ sources to make them consistent
Posted by GitBox <gi...@apache.org>.
thiru-mg merged pull request #1154:
URL: https://github.com/apache/avro/pull/1154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] emkornfield commented on pull request #1154: AVRO-3051: Reformatted C++ sources to make them consistent
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #1154:
URL: https://github.com/apache/avro/pull/1154#issuecomment-808549720
Skimmed and looks good to me, as well. A heads up to the ML might still be worthwhile because people like to bikeshed this stuff. As a follow-up it would be great to add a CI rule that verifies applying PRs are consistent with clang-format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1154: AVRO-3051: Reformatted C++ sources to make them consistent
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1154:
URL: https://github.com/apache/avro/pull/1154#issuecomment-808104254
Awesome for the script, thanks! LGTM, I checked that:
1. `m̀aster` + `.clang-format` (1.10.1) with returns _essentially_ the results in this branch (one or two whitespace choices), and
2. this commit is consistent with the rules provided: `./build.sh format` doesn't make any diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] thiru-mg commented on pull request #1154: AVRO-3051: Reformatted C++ sources to make them consistent
Posted by GitBox <gi...@apache.org>.
thiru-mg commented on pull request #1154:
URL: https://github.com/apache/avro/pull/1154#issuecomment-808010659
> Hello! I checked that there's no functional changes, just whitespace and formatting, so LGTM from that point. I have no opinion on the formatting used.
>
> It would be great to put the name of the beautifier tool and/or settings in the lang/c++/readme file for future reference as a best practice. I find that very helpful when contributing to a new project!
I added a new config file `.clang-format` and build target `format`. Now `./build.sh format` will format the code provided `clang-format` has been installed on the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org