You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by tushargosavi <gi...@git.apache.org> on 2016/07/22 06:41:06 UTC
[GitHub] apex-core pull request #361: APEXCORE-496 make operator name available to St...
GitHub user tushargosavi opened a pull request:
https://github.com/apache/apex-core/pull/361
APEXCORE-496 make operator name available to StatsListener.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tushargosavi/incubator-apex-core APEXCORE-496
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-core/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 57bcad19ba9b2b94ac752a46bd7b6ef3b6ca2249
Author: Tushar R. Gosavi <tu...@apache.org>
Date: 2016-07-22T06:39:36Z
APEXCORE-496 make operator name available to StatsListener.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #361: APEXCORE-496 make operator name available to St...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/361#discussion_r71943358
--- Diff: api/src/main/java/com/datatorrent/api/StatsListener.java ---
@@ -113,6 +113,8 @@
long getLatencyMA();
List<OperatorResponse> getOperatorResponse();
+
+ String getOperatorName();
--- End diff --
Why operator name is part of BatchedOperatorStats when operator name does not change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #361: APEXCORE-496 make operator name available to St...
Posted by tushargosavi <gi...@git.apache.org>.
Github user tushargosavi closed the pull request at:
https://github.com/apache/apex-core/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #361: APEXCORE-496 make operator name available to St...
Posted by sandeshh <gi...@git.apache.org>.
Github user sandeshh commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/361#discussion_r74098254
--- Diff: api/src/main/java/com/datatorrent/api/StatsListener.java ---
@@ -115,6 +115,28 @@
List<OperatorResponse> getOperatorResponse();
}
+ /**
+ * An interface to the DAG. Stats listener can get information about
+ * operator or other elements in the DAG through this interface. currerntly
+ * we only provide method to extract the operator name based on the physical
+ * id of the operator. In future more methods can be added.
+ *
+ */
--- End diff --
For the batch scheduling support, having the DAG view available for the operator will be useful. Users should be able to extract the information from the DAG view. Exposing the method for every information may not be ideal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core issue #361: APEXCORE-496 make operator name available to StatsList...
Posted by tushargosavi <gi...@git.apache.org>.
Github user tushargosavi commented on the issue:
https://github.com/apache/apex-core/pull/361
@vrozov @sandeshh I have updated the pull request please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #361: APEXCORE-496 make operator name available to St...
Posted by tushargosavi <gi...@git.apache.org>.
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/361#discussion_r73645793
--- Diff: api/src/main/java/com/datatorrent/api/StatsListener.java ---
@@ -113,6 +113,8 @@
long getLatencyMA();
List<OperatorResponse> getOperatorResponse();
+
+ String getOperatorName();
--- End diff --
stat listener only have access to the BatchedOperatorStats, hence added it as part of it. I am closing this pull request now. Making changes as per discussion on the dev thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #361: APEXCORE-496 make operator name available to St...
Posted by tushargosavi <gi...@git.apache.org>.
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/361#discussion_r74229007
--- Diff: api/src/main/java/com/datatorrent/api/StatsListener.java ---
@@ -115,6 +115,28 @@
List<OperatorResponse> getOperatorResponse();
}
+ /**
+ * An interface to the DAG. Stats listener can get information about
+ * operator or other elements in the DAG through this interface. currerntly
+ * we only provide method to extract the operator name based on the physical
+ * id of the operator. In future more methods can be added.
+ *
+ */
--- End diff --
exposing all information may expose internal implementation of the DAG. we can only have dependency on apex-api. Can you suggest which information can be provided to stat listener without adding dependency on the apex-engine. I can think of following
- name
- number of partitions for self.
- aggregated stats at logical operator level.
This list could be expanded in future.
This jira puts the required infrastructure without breaking backward compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---