You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by ni...@apache.org on 2018/11/02 09:34:59 UTC
[03/12] ignite git commit: IGNITE-9312: Remove unnecessary
@SuppressWarnings annotation - Fixes #4632.
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/checkpoint/GridCheckpointSpiAbstractTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/checkpoint/GridCheckpointSpiAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/spi/checkpoint/GridCheckpointSpiAbstractTest.java
index 489f53e..03fd5e6 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/checkpoint/GridCheckpointSpiAbstractTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/checkpoint/GridCheckpointSpiAbstractTest.java
@@ -24,7 +24,6 @@ import org.apache.ignite.testframework.junits.spi.GridSpiAbstractTest;
* Grid checkpoint SPI abstract test.
* @param <T> Concrete SPI class.
*/
-@SuppressWarnings({"CatchGenericClass"})
public abstract class GridCheckpointSpiAbstractTest<T extends CheckpointSpi>
extends GridSpiAbstractTest<T> {
/** */
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/collision/priorityqueue/GridPriorityQueueCollisionSpiSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/collision/priorityqueue/GridPriorityQueueCollisionSpiSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/collision/priorityqueue/GridPriorityQueueCollisionSpiSelfTest.java
index 9484dec..6ecf5cf 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/collision/priorityqueue/GridPriorityQueueCollisionSpiSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/collision/priorityqueue/GridPriorityQueueCollisionSpiSelfTest.java
@@ -137,7 +137,6 @@ public class GridPriorityQueueCollisionSpiSelfTest extends GridSpiAbstractTest<P
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"RedundantTypeArguments"})
public void testCollision1() throws Exception {
List<CollisionJobContext> activeJobs = makeContextList(null);
List<CollisionJobContext> passiveJobs = makeContextList(null);
@@ -242,7 +241,7 @@ public class GridPriorityQueueCollisionSpiSelfTest extends GridSpiAbstractTest<P
((GridTestCollisionTaskSession)ctx.getTaskSession()).setPriorityAttributeKey("bad-attr-name");
((GridTestCollisionJobContext)ctx).setJobContext(new GridTestJobContext() {
- @SuppressWarnings({"unchecked", "RedundantTypeArguments"})
+ @SuppressWarnings({"RedundantTypeArguments"})
@Override public <K, V> V getAttribute(K key) {
if (DFLT_JOB_PRIORITY_ATTRIBUTE_KEY.equals(key))
return null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/communication/GridAbstractCommunicationSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/communication/GridAbstractCommunicationSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/communication/GridAbstractCommunicationSelfTest.java
index e51dac8..cec63df 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/communication/GridAbstractCommunicationSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/communication/GridAbstractCommunicationSelfTest.java
@@ -51,7 +51,6 @@ import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_MACS;
* Super class for all communication self tests.
* @param <T> Type of communication SPI.
*/
-@SuppressWarnings({"JUnitAbstractTestClassNamingConvention"})
public abstract class GridAbstractCommunicationSelfTest<T extends CommunicationSpi> extends GridSpiAbstractTest<T> {
/** */
private static long msgId = 1;
@@ -89,7 +88,6 @@ public abstract class GridAbstractCommunicationSelfTest<T extends CommunicationS
}
/** */
- @SuppressWarnings({"deprecation"})
private class MessageListener implements CommunicationListener<Message> {
/** */
private final UUID locNodeId;
@@ -195,7 +193,6 @@ public abstract class GridAbstractCommunicationSelfTest<T extends CommunicationS
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("WaitWithoutCorrespondingNotify")
public void testSendToManyNodes() throws Exception {
msgDestMap.clear();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridCacheDhtLockBackupSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridCacheDhtLockBackupSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridCacheDhtLockBackupSelfTest.java
index 951971d..ee1f180 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridCacheDhtLockBackupSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridCacheDhtLockBackupSelfTest.java
@@ -102,7 +102,6 @@ public class GridCacheDhtLockBackupSelfTest extends GridCommonAbstractTest {
/**
* @throws Exception If test failed.
*/
- @SuppressWarnings({"TooBroadScope"})
public void testLock() throws Exception {
final int kv = 1;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiLanLoadTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiLanLoadTest.java b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiLanLoadTest.java
index 93a1597..0585b3d 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiLanLoadTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiLanLoadTest.java
@@ -45,7 +45,6 @@ import org.apache.ignite.testframework.junits.spi.GridSpiAbstractTest;
/**
* Class for multithreaded {@link TcpCommunicationSpi} test.
*/
-@SuppressWarnings({"JUnitAbstractTestClassNamingConvention"})
public class GridTcpCommunicationSpiLanLoadTest extends GridSpiAbstractTest<TcpCommunicationSpi> {
/** Connection idle timeout */
public static final int IDLE_CONN_TIMEOUT = 2000;
@@ -86,7 +85,6 @@ public class GridTcpCommunicationSpiLanLoadTest extends GridSpiAbstractTest<TcpC
/**
* Accumulating listener.
*/
- @SuppressWarnings({"deprecation"})
private class MessageListener implements CommunicationListener<Message> {
/** Node id of local node. */
private final UUID locNodeId;
@@ -265,7 +263,6 @@ public class GridTcpCommunicationSpiLanLoadTest extends GridSpiAbstractTest<TcpC
}
/** {@inheritDoc} */
- @SuppressWarnings({"NullableProblems"})
@Override protected void afterTestsStopped() throws Exception {
spi.setListener(null);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiMultithreadedSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiMultithreadedSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiMultithreadedSelfTest.java
index d610bc3..86a1109 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiMultithreadedSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiMultithreadedSelfTest.java
@@ -67,7 +67,6 @@ import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_MACS;
/**
* Class for multithreaded {@link TcpCommunicationSpi} test.
*/
-@SuppressWarnings({"JUnitAbstractTestClassNamingConvention"})
public class GridTcpCommunicationSpiMultithreadedSelfTest extends GridSpiAbstractTest<TcpCommunicationSpi> {
/** Connection idle timeout */
public static final int IDLE_CONN_TIMEOUT = 2000;
@@ -126,7 +125,6 @@ public class GridTcpCommunicationSpiMultithreadedSelfTest extends GridSpiAbstrac
/**
* Accumulating listener.
*/
- @SuppressWarnings({"deprecation"})
private static class MessageListener implements CommunicationListener<Message> {
/** Node id of local node. */
private final UUID locNodeId;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoveryAckSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoveryAckSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoveryAckSelfTest.java
index 1467c29..e8a535b 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoveryAckSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoveryAckSelfTest.java
@@ -338,7 +338,6 @@ public class GridTcpCommunicationSpiRecoveryAckSelfTest<T extends CommunicationS
* @return Session.
* @throws Exception If failed.
*/
- @SuppressWarnings("unchecked")
private GridNioSession communicationSession(TcpCommunicationSpi spi) throws Exception {
final GridNioServer srv = U.field(spi, "nioSrvr");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoverySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoverySelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoverySelfTest.java
index d2e18c0..5d09fbb 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoverySelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/GridTcpCommunicationSpiRecoverySelfTest.java
@@ -217,7 +217,6 @@ public class GridTcpCommunicationSpiRecoverySelfTest<T extends CommunicationSpi>
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("BusyWait")
private void checkBlockListener() throws Exception {
TcpCommunicationSpi spi0 = spis.get(0);
TcpCommunicationSpi spi1 = spis.get(1);
@@ -671,7 +670,6 @@ public class GridTcpCommunicationSpiRecoverySelfTest<T extends CommunicationSpi>
* @return Session.
* @throws Exception If failed.
*/
- @SuppressWarnings("unchecked")
private GridNioSession communicationSession(TcpCommunicationSpi spi, boolean in) throws Exception {
final GridNioServer srv = U.field(spi, "nioSrvr");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/IgniteTcpCommunicationRecoveryAckClosureSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/IgniteTcpCommunicationRecoveryAckClosureSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/IgniteTcpCommunicationRecoveryAckClosureSelfTest.java
index 1c2bf04..8f8d101 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/IgniteTcpCommunicationRecoveryAckClosureSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/communication/tcp/IgniteTcpCommunicationRecoveryAckClosureSelfTest.java
@@ -389,7 +389,6 @@ public class IgniteTcpCommunicationRecoveryAckClosureSelfTest<T extends Communic
* @return Session.
* @throws Exception If failed.
*/
- @SuppressWarnings("unchecked")
private GridNioSession communicationSession(TcpCommunicationSpi spi) throws Exception {
final GridNioServer srv = U.field(spi, "nioSrvr");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryRandomStartStopTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryRandomStartStopTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryRandomStartStopTest.java
index 3614987..27cffe9 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryRandomStartStopTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryRandomStartStopTest.java
@@ -57,7 +57,6 @@ public abstract class AbstractDiscoveryRandomStartStopTest<T extends DiscoverySp
private volatile boolean canceled;
/** {@inheritDoc} */
- @SuppressWarnings({"UnusedCatchParameter"})
@Override public void run() {
while (!canceled) {
try {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoverySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoverySelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoverySelfTest.java
index 3e0fb89..c21e52d 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoverySelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoverySelfTest.java
@@ -55,7 +55,6 @@ import static org.apache.ignite.lang.IgniteProductVersion.fromString;
* Base discovery self-test class.
* @param <T> SPI implementation class.
*/
-@SuppressWarnings({"JUnitAbstractTestClassNamingConvention"})
public abstract class AbstractDiscoverySelfTest<T extends IgniteSpi> extends GridSpiAbstractTest<T> {
/** */
private static final String HTTP_ADAPTOR_MBEAN_NAME = "mbeanAdaptor:protocol=HTTP";
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryTest.java
index 2c2d99a..352ebe6 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/AbstractDiscoveryTest.java
@@ -34,7 +34,6 @@ import org.apache.ignite.testframework.junits.spi.GridSpiAbstractTest;
* Base discovery test class.
* @param <T> SPI implementation class.
*/
-@SuppressWarnings({"JUnitAbstractTestClassNamingConvention"})
public abstract class AbstractDiscoveryTest<T extends DiscoverySpi> extends GridSpiAbstractTest<T> {
/** */
@SuppressWarnings({"ClassExplicitlyExtendsThread"})
@@ -47,7 +46,6 @@ public abstract class AbstractDiscoveryTest<T extends DiscoverySpi> extends Grid
private boolean isCanceled;
/** {@inheritDoc} */
- @SuppressWarnings({"UnusedCatchParameter"})
@Override public void run() {
Random rnd = new Random();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryMultiThreadedTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryMultiThreadedTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryMultiThreadedTest.java
index 06021d2..8f3ce0a 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryMultiThreadedTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryMultiThreadedTest.java
@@ -107,7 +107,6 @@ public class TcpDiscoveryMultiThreadedTest extends GridCommonAbstractTest {
}
/** {@inheritDoc} */
- @SuppressWarnings({"IfMayBeConditional"})
@Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception {
IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiSelfTest.java
index 0704ad5..32b5605 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySpiSelfTest.java
@@ -26,7 +26,6 @@ import org.apache.ignite.testframework.junits.spi.GridSpiTest;
/**
* TCP discovery spi test.
*/
-@SuppressWarnings({"JUnitTestCaseWithNoTests"})
@GridSpiTest(spi = TcpDiscoverySpi.class, group = "Discovery SPI")
public class TcpDiscoverySpiSelfTest extends AbstractDiscoverySelfTest<TcpDiscoverySpi> {
/** */
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/TcpDiscoveryIpFinderAbstractSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/TcpDiscoveryIpFinderAbstractSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/TcpDiscoveryIpFinderAbstractSelfTest.java
index 465b38d..67966c0 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/TcpDiscoveryIpFinderAbstractSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/TcpDiscoveryIpFinderAbstractSelfTest.java
@@ -42,7 +42,6 @@ public abstract class TcpDiscoveryIpFinderAbstractSelfTest<T extends TcpDiscover
*
* @throws Exception If any error occurs.
*/
- @SuppressWarnings({"AbstractMethodCallInConstructor", "OverriddenMethodCallDuringObjectConstruction"})
protected TcpDiscoveryIpFinderAbstractSelfTest() throws Exception {
super(false);
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/multicast/TcpDiscoveryMulticastIpFinderSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/multicast/TcpDiscoveryMulticastIpFinderSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/multicast/TcpDiscoveryMulticastIpFinderSelfTest.java
index 29ed595..e0fd244 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/multicast/TcpDiscoveryMulticastIpFinderSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/multicast/TcpDiscoveryMulticastIpFinderSelfTest.java
@@ -48,7 +48,7 @@ public class TcpDiscoveryMulticastIpFinderSelfTest
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"TooBroadScope", "BusyWait"})
+ @SuppressWarnings({"TooBroadScope"})
public void testExchange() throws Exception {
String locAddr = null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/eventstorage/memory/GridMemoryEventStorageSpiSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/eventstorage/memory/GridMemoryEventStorageSpiSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/eventstorage/memory/GridMemoryEventStorageSpiSelfTest.java
index 0eb2df8..c8f530a 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/eventstorage/memory/GridMemoryEventStorageSpiSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/eventstorage/memory/GridMemoryEventStorageSpiSelfTest.java
@@ -101,7 +101,6 @@ public class GridMemoryEventStorageSpiSelfTest extends GridSpiAbstractTest<Memor
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"NullableProblems"})
public void testFilter() throws Exception {
MemoryEventStorageSpi spi = getSpi();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/failover/always/GridAlwaysFailoverSpiSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/failover/always/GridAlwaysFailoverSpiSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/failover/always/GridAlwaysFailoverSpiSelfTest.java
index 98f2b07..6a37299 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/failover/always/GridAlwaysFailoverSpiSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/failover/always/GridAlwaysFailoverSpiSelfTest.java
@@ -57,7 +57,6 @@ public class GridAlwaysFailoverSpiSelfTest extends GridSpiAbstractTest<AlwaysFai
/**
* @throws Exception If test failed.
*/
- @SuppressWarnings("unchecked")
public void testTwoNodes() throws Exception {
AlwaysFailoverSpi spi = getSpi();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/adaptive/GridAdaptiveLoadBalancingSpiStartStopSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/adaptive/GridAdaptiveLoadBalancingSpiStartStopSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/adaptive/GridAdaptiveLoadBalancingSpiStartStopSelfTest.java
index fbc10e1..6805689 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/adaptive/GridAdaptiveLoadBalancingSpiStartStopSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/adaptive/GridAdaptiveLoadBalancingSpiStartStopSelfTest.java
@@ -23,7 +23,6 @@ import org.apache.ignite.testframework.junits.spi.GridSpiTest;
/**
* Adaptive load balancing SPI start-stop test.
*/
-@SuppressWarnings({"JUnitTestCaseWithNoTests"})
@GridSpiTest(spi = AdaptiveLoadBalancingSpi.class, group = "LoadBalancing SPI")
public class GridAdaptiveLoadBalancingSpiStartStopSelfTest extends
GridSpiStartStopAbstractTest<AdaptiveLoadBalancingSpi> {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/roundrobin/GridRoundRobinLoadBalancingSpiStartStopSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/roundrobin/GridRoundRobinLoadBalancingSpiStartStopSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/roundrobin/GridRoundRobinLoadBalancingSpiStartStopSelfTest.java
index c35b50e..febd036 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/roundrobin/GridRoundRobinLoadBalancingSpiStartStopSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/roundrobin/GridRoundRobinLoadBalancingSpiStartStopSelfTest.java
@@ -23,7 +23,6 @@ import org.apache.ignite.testframework.junits.spi.GridSpiTest;
/**
* Tests correct start of {@link RoundRobinLoadBalancingSpi}.
*/
-@SuppressWarnings({"JUnitTestCaseWithNoTests"})
@GridSpiTest(spi = RoundRobinLoadBalancingSpi.class, group = "LoadBalancing SPI")
public class GridRoundRobinLoadBalancingSpiStartStopSelfTest
extends GridSpiStartStopAbstractTest<RoundRobinLoadBalancingSpi> {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/weightedrandom/GridWeightedRandomLoadBalancingSpiStartStopSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/weightedrandom/GridWeightedRandomLoadBalancingSpiStartStopSelfTest.java b/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/weightedrandom/GridWeightedRandomLoadBalancingSpiStartStopSelfTest.java
index f76d6ab..4b380b0 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/weightedrandom/GridWeightedRandomLoadBalancingSpiStartStopSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/loadbalancing/weightedrandom/GridWeightedRandomLoadBalancingSpiStartStopSelfTest.java
@@ -23,7 +23,6 @@ import org.apache.ignite.testframework.junits.spi.GridSpiTest;
/**
* Wighted random load balancing SPI start-stop test.
*/
-@SuppressWarnings({"JUnitTestCaseWithNoTests"})
@GridSpiTest(spi = WeightedRandomLoadBalancingSpi.class, group = "LoadBalancing SPI")
public class GridWeightedRandomLoadBalancingSpiStartStopSelfTest extends
GridSpiStartStopAbstractTest<WeightedRandomLoadBalancingSpi> {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/startup/GridRandomCommandLineLoader.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/startup/GridRandomCommandLineLoader.java b/modules/core/src/test/java/org/apache/ignite/startup/GridRandomCommandLineLoader.java
index 9284b8a..65e8f46 100644
--- a/modules/core/src/test/java/org/apache/ignite/startup/GridRandomCommandLineLoader.java
+++ b/modules/core/src/test/java/org/apache/ignite/startup/GridRandomCommandLineLoader.java
@@ -299,7 +299,6 @@ public final class GridRandomCommandLineLoader {
* @return List of configurations.
* @throws IgniteCheckedException If an error occurs.
*/
- @SuppressWarnings("unchecked")
private static IgniteConfiguration getConfiguration(String springCfgPath, @Nullable String logCfgPath)
throws IgniteCheckedException {
assert springCfgPath != null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/startup/servlet/GridServletLoaderTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/startup/servlet/GridServletLoaderTest.java b/modules/core/src/test/java/org/apache/ignite/startup/servlet/GridServletLoaderTest.java
index 3345aed..4ce89a2 100644
--- a/modules/core/src/test/java/org/apache/ignite/startup/servlet/GridServletLoaderTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/startup/servlet/GridServletLoaderTest.java
@@ -68,7 +68,6 @@ public class GridServletLoaderTest extends GridCommonAbstractTest {
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"unchecked"})
public void testLoader() throws Exception {
JMXConnector jmx = null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/GridSpiTestContext.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/GridSpiTestContext.java b/modules/core/src/test/java/org/apache/ignite/testframework/GridSpiTestContext.java
index 51dcb23..1b38857 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/GridSpiTestContext.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/GridSpiTestContext.java
@@ -84,7 +84,6 @@ public class GridSpiTestContext implements IgniteSpiContext {
private final Map<GridLocalEventListener, Set<Integer>> evtLsnrs = new HashMap<>();
/** */
- @SuppressWarnings("deprecation")
private final Collection<GridMessageListener> msgLsnrs = new ArrayList<>();
/** */
@@ -327,14 +326,12 @@ public class GridSpiTestContext implements IgniteSpiContext {
* @param node Destination node.
* @param msg Message.
*/
- @SuppressWarnings("deprecation")
public void triggerMessage(ClusterNode node, Object msg) {
for (GridMessageListener lsnr : msgLsnrs)
lsnr.onMessage(node.id(), msg, GridIoPolicy.SYSTEM_POOL);
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public void addLocalMessageListener(Object topic, IgniteBiPredicate<UUID, ?> p) {
try {
addMessageListener(TOPIC_COMM_USER,
@@ -349,25 +346,21 @@ public class GridSpiTestContext implements IgniteSpiContext {
* @param topic Listener's topic.
* @param lsnr Listener to add.
*/
- @SuppressWarnings({"TypeMayBeWeakened", "deprecation"})
public void addMessageListener(GridTopic topic, GridMessageListener lsnr) {
addMessageListener(lsnr, ((Object)topic).toString());
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public void addMessageListener(GridMessageListener lsnr, String topic) {
msgLsnrs.add(lsnr);
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public boolean removeMessageListener(GridMessageListener lsnr, String topic) {
return msgLsnrs.remove(lsnr);
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public void removeLocalMessageListener(Object topic, IgniteBiPredicate<UUID, ?> p) {
try {
removeMessageListener(TOPIC_COMM_USER,
@@ -383,7 +376,6 @@ public class GridSpiTestContext implements IgniteSpiContext {
* @param lsnr Listener to remove.
* @return Whether or not the lsnr was removed.
*/
- @SuppressWarnings("deprecation")
public boolean removeMessageListener(GridTopic topic, @Nullable GridMessageListener lsnr) {
return removeMessageListener(lsnr, ((Object)topic).toString());
}
@@ -681,9 +673,7 @@ public class GridSpiTestContext implements IgniteSpiContext {
}
/** {@inheritDoc} */
- @SuppressWarnings({
- "SynchronizationOnLocalVariableOrMethodParameter", "ConstantConditions",
- "OverlyStrongTypeCast"})
+ @SuppressWarnings("ConstantConditions")
@Override public void onMessage(UUID nodeId, Object msg, byte plc) {
GridIoUserMessage ioMsg = (GridIoUserMessage)msg;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/GridTestExternalClassLoader.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestExternalClassLoader.java b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestExternalClassLoader.java
index 5064a17..561ef55 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestExternalClassLoader.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestExternalClassLoader.java
@@ -144,7 +144,6 @@ public class GridTestExternalClassLoader extends URLClassLoader {
}
/** {@inheritDoc} */
- @SuppressWarnings({"NonSynchronizedMethodOverridesSynchronizedMethod"})
@Override protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundException {
if (excludeClassNames.contains(name))
throw new ClassNotFoundException(name);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/GridTestNode.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestNode.java b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestNode.java
index cefb774..4f23825 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestNode.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestNode.java
@@ -155,7 +155,6 @@ public class GridTestNode extends GridMetadataAwareAdapter implements ClusterNod
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public Map<String, Object> attributes() {
return attrs;
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/GridTestThread.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestThread.java b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestThread.java
index f4a346e..f2cec0f 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestThread.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestThread.java
@@ -22,7 +22,7 @@ import java.util.concurrent.Callable;
/**
* Test thread that has convenience failure checks.
*/
-@SuppressWarnings({"ProhibitedExceptionThrown", "CatchGenericClass"})
+@SuppressWarnings({"ProhibitedExceptionThrown"})
public class GridTestThread extends Thread {
/** Error. */
private Throwable err;
@@ -36,7 +36,6 @@ public class GridTestThread extends Thread {
/**
* @param run Target runnable.
*/
- @SuppressWarnings({"NullableProblems"})
public GridTestThread(Runnable run) {
this(run, null);
}
@@ -44,7 +43,6 @@ public class GridTestThread extends Thread {
/**
* @param call Target callable.
*/
- @SuppressWarnings({"NullableProblems"})
public GridTestThread(Callable<?> call) {
this(call, null);
}
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
index ad55e40..295e40a 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java
@@ -111,7 +111,6 @@ import org.jetbrains.annotations.Nullable;
/**
* Utility class for tests.
*/
-@SuppressWarnings({"UnusedCatchParameter"})
public final class GridTestUtils {
/** Default busy wait sleep interval in milliseconds. */
public static final long DFLT_BUSYWAIT_SLEEP_INTERVAL = 200;
@@ -826,7 +825,6 @@ public final class GridTestUtils {
* @param threadName Thread names.
* @return Future for the run. Future returns execution time in milliseconds.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
public static IgniteInternalFuture<Long> runMultiThreadedAsync(Callable<?> call, int threadNum, final String threadName) {
final List<Callable<?>> calls = Collections.<Callable<?>>nCopies(threadNum, call);
final GridTestSafeThreadFactory threadFactory = new GridTestSafeThreadFactory(threadName);
@@ -929,7 +927,6 @@ public final class GridTestUtils {
* @param task Runnable.
* @return Future with task result.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
public static IgniteInternalFuture runAsync(final Runnable task) {
return runAsync(task,"async-runnable-runner");
}
@@ -940,7 +937,6 @@ public final class GridTestUtils {
* @param task Runnable.
* @return Future with task result.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
public static IgniteInternalFuture runAsync(final Runnable task, String threadName) {
return runAsync(() -> {
task.run();
@@ -955,7 +951,6 @@ public final class GridTestUtils {
* @param task Callable.
* @return Future with task result.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
public static <T> IgniteInternalFuture<T> runAsync(final Callable<T> task) {
return runAsync(task, "async-callable-runner");
}
@@ -967,7 +962,6 @@ public final class GridTestUtils {
* @param threadName Thread name.
* @return Future with task result.
*/
- @SuppressWarnings("ExternalizableWithoutPublicNoArgConstructor")
public static <T> IgniteInternalFuture<T> runAsync(final Callable<T> task, String threadName) {
if (!busyLock.enterBusy())
throw new IllegalStateException("Failed to start new threads (test is being stopped).");
@@ -1161,7 +1155,6 @@ public final class GridTestUtils {
* @param ignite Grid to stop.
* @param log Logger.
*/
- @SuppressWarnings({"CatchGenericClass"})
public static void close(Ignite ignite, IgniteLogger log) {
if (ignite != null)
try {
@@ -1179,7 +1172,6 @@ public final class GridTestUtils {
* @param igniteInstanceName Ignite instance name.
* @param log Logger.
*/
- @SuppressWarnings({"CatchGenericClass"})
public static void stopGrid(String igniteInstanceName, IgniteLogger log) {
try {
G.stop(igniteInstanceName, false);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsFactory.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsFactory.java b/modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsFactory.java
index 2d94109..0dbb675 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsFactory.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/configvariations/ConfigVariationsFactory.java
@@ -62,7 +62,6 @@ public class ConfigVariationsFactory implements ConfigFactory {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public IgniteConfiguration getConfiguration(String igniteInstanceName, IgniteConfiguration srcCfg) {
IgniteConfiguration cfg = new IgniteConfiguration();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/junits/common/GridCommonAbstractTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/common/GridCommonAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/common/GridCommonAbstractTest.java
index a06f15a..27a25ac 100755
--- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/common/GridCommonAbstractTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/common/GridCommonAbstractTest.java
@@ -528,7 +528,6 @@ public abstract class GridCommonAbstractTest extends GridAbstractTest {
/**
* @throws InterruptedException If interrupted.
*/
- @SuppressWarnings("BusyWait")
protected void awaitPartitionMapExchange() throws InterruptedException {
awaitPartitionMapExchange(false, false, null);
}
@@ -540,7 +539,6 @@ public abstract class GridCommonAbstractTest extends GridAbstractTest {
* be filtered
* @throws InterruptedException If interrupted.
*/
- @SuppressWarnings("BusyWait")
protected void awaitPartitionMapExchange(
boolean waitEvicts,
boolean waitNode2PartUpdate,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java
index 101d016..82bf417 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java
@@ -171,7 +171,7 @@ public abstract class GridSpiAbstractTest<T extends IgniteSpi> extends GridAbstr
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"unchecked", "CastToIncompatibleInterface", "InstanceofIncompatibleInterface"})
+ @SuppressWarnings({"unchecked"})
protected final void spiStart() throws Exception {
GridSpiTest spiTest = GridTestUtils.getAnnotation(getClass(), GridSpiTest.class);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTest.java
index 7d1c211..c66cb1f 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTest.java
@@ -31,7 +31,6 @@ import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
* Annotates all tests in SPI test framework. Provides implementation class of the SPI and
* optional dependencies.
*/
-@SuppressWarnings({"JavaDoc"})
@Documented
@Inherited
@Retention(RetentionPolicy.RUNTIME)
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTestConfig.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTestConfig.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTestConfig.java
index d232a40..b31b38d 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTestConfig.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiTestConfig.java
@@ -26,7 +26,6 @@ import java.lang.annotation.Target;
/**
* Annotates a getter method value of which is used to configure implementation SPI.
*/
-@SuppressWarnings({"JavaDoc"})
@Documented
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.METHOD})
@@ -45,7 +44,7 @@ public @interface GridSpiTestConfig {
}
/** */
- @SuppressWarnings({"JavaDoc"}) ConfigType type() default ConfigType.SELF;
+ ConfigType type() default ConfigType.SELF;
/** */
String setterName() default "";
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/test/ParametersTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/test/ParametersTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/test/ParametersTest.java
index 736db12..7d94bb2 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/test/ParametersTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/test/ParametersTest.java
@@ -60,7 +60,6 @@ public class ParametersTest extends TestCase {
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("unchecked")
public void testEnumVariationsWithNull() throws Exception {
ConfigParameter<CacheConfiguration>[] cfgParam =
Parameters.enumParameters(true, "setCacheMode", CacheMode.class);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/testframework/test/VariationsIteratorTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/test/VariationsIteratorTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/test/VariationsIteratorTest.java
index d8ac2b3..0e0118b 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/test/VariationsIteratorTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/test/VariationsIteratorTest.java
@@ -43,7 +43,6 @@ public class VariationsIteratorTest extends TestCase {
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("PointlessArithmeticExpression")
public void test2() throws Exception {
Object[][] arr = new Object[][] {
{0},
@@ -58,7 +57,6 @@ public class VariationsIteratorTest extends TestCase {
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("PointlessArithmeticExpression")
public void test3() throws Exception {
Object[][] arr = new Object[][] {
{0, 1, 2, 3, 4, 5},
@@ -73,7 +71,6 @@ public class VariationsIteratorTest extends TestCase {
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("PointlessArithmeticExpression")
public void test4() throws Exception {
Object[][] arr = new Object[][]{
{0,1,2},
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/util/AttributeNodeFilterSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/util/AttributeNodeFilterSelfTest.java b/modules/core/src/test/java/org/apache/ignite/util/AttributeNodeFilterSelfTest.java
index 2463d9a..580835c 100644
--- a/modules/core/src/test/java/org/apache/ignite/util/AttributeNodeFilterSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/util/AttributeNodeFilterSelfTest.java
@@ -172,7 +172,6 @@ public class AttributeNodeFilterSelfTest extends GridCommonAbstractTest {
ClusterNode.class.getClassLoader(),
new Class[] { ClusterNode.class },
new InvocationHandler() {
- @SuppressWarnings("SuspiciousMethodCalls")
@Override public Object invoke(Object proxy, Method mtd, Object[] args) throws Throwable {
if ("attributes".equals(mtd.getName()))
return attrs;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/core/src/test/java/org/apache/ignite/util/GridConcurrentLinkedDequeMultiThreadedTest.java
----------------------------------------------------------------------
diff --git a/modules/core/src/test/java/org/apache/ignite/util/GridConcurrentLinkedDequeMultiThreadedTest.java b/modules/core/src/test/java/org/apache/ignite/util/GridConcurrentLinkedDequeMultiThreadedTest.java
index 99064f0..83cb209 100644
--- a/modules/core/src/test/java/org/apache/ignite/util/GridConcurrentLinkedDequeMultiThreadedTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/util/GridConcurrentLinkedDequeMultiThreadedTest.java
@@ -36,7 +36,6 @@ public class GridConcurrentLinkedDequeMultiThreadedTest extends GridCommonAbstra
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"BusyWait"})
public void testQueueMultiThreaded() throws Exception {
final AtomicBoolean done = new AtomicBoolean();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/GridExternalAffinityFunction.java
----------------------------------------------------------------------
diff --git a/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/GridExternalAffinityFunction.java b/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/GridExternalAffinityFunction.java
index 7189867..6520742 100644
--- a/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/GridExternalAffinityFunction.java
+++ b/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/GridExternalAffinityFunction.java
@@ -63,7 +63,6 @@ public class GridExternalAffinityFunction implements AffinityFunction {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public List<List<ClusterNode>> assignPartitions(AffinityFunctionContext ctx) {
List<List<ClusterNode>> res = new ArrayList<>(partitions());
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/JobStealingTask.java
----------------------------------------------------------------------
diff --git a/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/JobStealingTask.java b/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/JobStealingTask.java
index b43f4cd..0b6413b 100644
--- a/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/JobStealingTask.java
+++ b/modules/extdata/p2p/src/main/java/org/apache/ignite/tests/p2p/JobStealingTask.java
@@ -50,7 +50,6 @@ public class JobStealingTask extends ComputeTaskAdapter<Object, Map<UUID, Intege
private IgniteLogger log;
/** {@inheritDoc} */
- @SuppressWarnings("ForLoopReplaceableByForEach")
@Override public Map<? extends ComputeJob, ClusterNode> map(List<ClusterNode> subgrid,
@Nullable Object arg) {
assert !subgrid.isEmpty();
@@ -65,7 +64,6 @@ public class JobStealingTask extends ComputeTaskAdapter<Object, Map<UUID, Intege
}
/** {@inheritDoc} */
- @SuppressWarnings("SuspiciousMethodCalls")
@Override public Map<UUID, Integer> reduce(List<ComputeJobResult> results) {
Map<UUID, Integer> ret = U.newHashMap(results.size());
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask1.java
----------------------------------------------------------------------
diff --git a/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask1.java b/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask1.java
index 0cbc63a..ac0f2b5 100644
--- a/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask1.java
+++ b/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask1.java
@@ -31,7 +31,6 @@ import org.springframework.core.io.ClassPathResource;
*/
public class GridUriDeploymentTestTask1 extends ComputeTaskSplitAdapter<Object, Object> {
/** */
- @SuppressWarnings({"unchecked", "TypeMayBeWeakened"})
public GridUriDeploymentTestTask1() {
XmlBeanFactory factory = new XmlBeanFactory(new ClassPathResource("spring1.xml", getClass().getClassLoader()));
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask2.java
----------------------------------------------------------------------
diff --git a/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask2.java b/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask2.java
index e354b42..1325efd 100644
--- a/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask2.java
+++ b/modules/extdata/uri/src/main/java/org/apache/ignite/spi/deployment/uri/tasks/GridUriDeploymentTestTask2.java
@@ -34,7 +34,6 @@ public class GridUriDeploymentTestTask2 extends ComputeTaskSplitAdapter<Object,
private static final long serialVersionUID = 172455091783232848L;
/** */
- @SuppressWarnings("unchecked")
public GridUriDeploymentTestTask2() {
XmlBeanFactory factory = new XmlBeanFactory(
new ClassPathResource("org/apache/ignite/spi/deployment/uri/tasks/spring2.xml",
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/flink/src/main/java/org/apache/ignite/sink/flink/IgniteSink.java
----------------------------------------------------------------------
diff --git a/modules/flink/src/main/java/org/apache/ignite/sink/flink/IgniteSink.java b/modules/flink/src/main/java/org/apache/ignite/sink/flink/IgniteSink.java
index ad29490..8deb0d7 100644
--- a/modules/flink/src/main/java/org/apache/ignite/sink/flink/IgniteSink.java
+++ b/modules/flink/src/main/java/org/apache/ignite/sink/flink/IgniteSink.java
@@ -138,7 +138,6 @@ public class IgniteSink<IN> extends RichSinkFunction<IN> {
* @throws IgniteException If failed.
*/
@Override
- @SuppressWarnings("unchecked")
public void open(Configuration parameter) {
A.notNull(igniteCfgFile, "Ignite config file");
A.notNull(cacheName, "Cache name");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v1/IgniteHadoopFileSystem.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v1/IgniteHadoopFileSystem.java b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v1/IgniteHadoopFileSystem.java
index efb1a45..345d5bc 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v1/IgniteHadoopFileSystem.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v1/IgniteHadoopFileSystem.java
@@ -126,7 +126,6 @@ public class IgniteHadoopFileSystem extends FileSystem {
private short dfltReplication;
/** Base file system uri. */
- @SuppressWarnings("FieldAccessedSynchronizedAndUnsynchronized")
private URI uri;
/** Authority. */
@@ -200,7 +199,6 @@ public class IgniteHadoopFileSystem extends FileSystem {
*
* @param colocateFileWrites Whether all ongoing file writes should be colocated.
*/
- @SuppressWarnings("UnusedDeclaration")
public void colocateFileWrites(boolean colocateFileWrites) {
this.colocateFileWrites = colocateFileWrites;
}
@@ -431,7 +429,6 @@ public class IgniteHadoopFileSystem extends FileSystem {
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public FSDataOutputStream create(Path f, final FsPermission perm, boolean overwrite, int bufSize,
short replication, long blockSize, Progressable progress) throws IOException {
A.notNull(f, "f");
@@ -492,7 +489,6 @@ public class IgniteHadoopFileSystem extends FileSystem {
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public FSDataOutputStream append(Path f, int bufSize, Progressable progress) throws IOException {
A.notNull(f, "f");
@@ -535,7 +531,6 @@ public class IgniteHadoopFileSystem extends FileSystem {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public boolean rename(Path src, Path dst) throws IOException {
A.notNull(src, "src");
A.notNull(dst, "dst");
@@ -582,7 +577,6 @@ public class IgniteHadoopFileSystem extends FileSystem {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public boolean delete(Path f, boolean recursive) throws IOException {
A.notNull(f, "f");
@@ -678,7 +672,6 @@ public class IgniteHadoopFileSystem extends FileSystem {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public boolean mkdirs(Path f, FsPermission perm) throws IOException {
A.notNull(f, "f");
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v2/IgniteHadoopFileSystem.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v2/IgniteHadoopFileSystem.java b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v2/IgniteHadoopFileSystem.java
index c9d4cbb..c0008e2 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v2/IgniteHadoopFileSystem.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/fs/v2/IgniteHadoopFileSystem.java
@@ -206,7 +206,6 @@ public class IgniteHadoopFileSystem extends AbstractFileSystem implements Closea
*
* @param colocateFileWrites Whether all ongoing file writes should be colocated.
*/
- @SuppressWarnings("UnusedDeclaration")
public void colocateFileWrites(boolean colocateFileWrites) {
this.colocateFileWrites = colocateFileWrites;
}
@@ -423,7 +422,6 @@ public class IgniteHadoopFileSystem extends AbstractFileSystem implements Closea
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public FSDataOutputStream createInternal(
Path f,
EnumSet<CreateFlag> flag,
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/hadoop/mapreduce/IgniteHadoopClientProtocolProvider.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/mapreduce/IgniteHadoopClientProtocolProvider.java b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/mapreduce/IgniteHadoopClientProtocolProvider.java
index 920e8b7..0590724 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/mapreduce/IgniteHadoopClientProtocolProvider.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/mapreduce/IgniteHadoopClientProtocolProvider.java
@@ -111,7 +111,6 @@ public class IgniteHadoopClientProtocolProvider extends ClientProtocolProvider {
* @return Client.
* @throws IOException If failed.
*/
- @SuppressWarnings("unchecked")
private MapReduceClient client(String clusterName, Collection<String> addrs) throws IOException {
while (true) {
MapReduceClient cli = cliMap.get(clusterName);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/hadoop/planner/HadoopAbstractMapReducePlanner.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/planner/HadoopAbstractMapReducePlanner.java b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/planner/HadoopAbstractMapReducePlanner.java
index dd01f11..2f4b24a 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/hadoop/planner/HadoopAbstractMapReducePlanner.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/hadoop/planner/HadoopAbstractMapReducePlanner.java
@@ -44,7 +44,6 @@ public abstract class HadoopAbstractMapReducePlanner implements HadoopMapReduceP
protected Ignite ignite;
/** Logger. */
- @SuppressWarnings("UnusedDeclaration")
@LoggerResource
protected IgniteLogger log;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java
index fe5d434..5340ad1 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/HadoopSplitWrapper.java
@@ -96,7 +96,6 @@ public class HadoopSplitWrapper extends HadoopInputSplit {
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
id = in.readInt();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/delegate/HadoopDelegateUtils.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/delegate/HadoopDelegateUtils.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/delegate/HadoopDelegateUtils.java
index 2059c8d..24e74fd 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/delegate/HadoopDelegateUtils.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/delegate/HadoopDelegateUtils.java
@@ -80,7 +80,6 @@ public class HadoopDelegateUtils {
* @param proxy Proxy.
* @return Delegate.
*/
- @SuppressWarnings("unchecked")
public static HadoopFileSystemFactoryDelegate fileSystemFactoryDelegate(ClassLoader ldr, Object proxy) {
String clsName = FACTORY_CLS_MAP.get(proxy.getClass().getName());
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopIgfsUtils.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopIgfsUtils.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopIgfsUtils.java
index 3349cbf..9491689 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopIgfsUtils.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopIgfsUtils.java
@@ -118,7 +118,6 @@ public class HadoopIgfsUtils {
* @param path Path for exceptions.
* @return Casted exception.
*/
- @SuppressWarnings("unchecked")
public static IOException cast(IgniteCheckedException e, @Nullable String path) {
assert e != null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopDaemon.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopDaemon.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopDaemon.java
index ea7128c..11262ff 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopDaemon.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopDaemon.java
@@ -23,7 +23,6 @@ import java.util.LinkedList;
/**
* Replacement for Hadoop {@code org.apache.hadoop.util.Daemon} class.
*/
-@SuppressWarnings("UnusedDeclaration")
public class HadoopDaemon extends Thread {
/** Lock object used for synchronization. */
private static final Object lock = new Object();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2CleanupTask.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2CleanupTask.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2CleanupTask.java
index 15e3d0f..df402c8 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2CleanupTask.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2CleanupTask.java
@@ -45,7 +45,6 @@ public class HadoopV2CleanupTask extends HadoopV2Task {
}
/** {@inheritDoc} */
- @SuppressWarnings("ConstantConditions")
@Override public void run0(HadoopV2TaskContext taskCtx) throws IgniteCheckedException {
JobContextImpl jobCtx = taskCtx.jobContext();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2Job.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2Job.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2Job.java
index 13a893f..0cf8f84 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2Job.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2Job.java
@@ -257,7 +257,7 @@ public class HadoopV2Job extends HadoopJobEx {
}
/** {@inheritDoc} */
- @SuppressWarnings({"unchecked", "MismatchedQueryAndUpdateOfCollection" })
+ @SuppressWarnings({"unchecked"})
@Override public HadoopTaskContext getTaskContext(HadoopTaskInfo info) throws IgniteCheckedException {
T2<HadoopTaskType, Integer> locTaskId = new T2<>(info.type(), info.taskNumber());
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2MapTask.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2MapTask.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2MapTask.java
index 1519199..d1901f0 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2MapTask.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2MapTask.java
@@ -43,7 +43,7 @@ public class HadoopV2MapTask extends HadoopV2Task {
}
/** {@inheritDoc} */
- @SuppressWarnings({"ConstantConditions", "unchecked"})
+ @SuppressWarnings({"unchecked"})
@Override public void run0(HadoopV2TaskContext taskCtx) throws IgniteCheckedException {
OutputFormat outputFormat = null;
Exception err = null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2ReduceTask.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2ReduceTask.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2ReduceTask.java
index 09e0634..15b79dd 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2ReduceTask.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2ReduceTask.java
@@ -47,7 +47,7 @@ public class HadoopV2ReduceTask extends HadoopV2Task {
}
/** {@inheritDoc} */
- @SuppressWarnings({"ConstantConditions", "unchecked"})
+ @SuppressWarnings({"unchecked"})
@Override public void run0(HadoopV2TaskContext taskCtx) throws IgniteCheckedException {
OutputFormat outputFormat = null;
Exception err = null;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2SetupTask.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2SetupTask.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2SetupTask.java
index b466019..ab31b27 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2SetupTask.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2SetupTask.java
@@ -40,7 +40,6 @@ public class HadoopV2SetupTask extends HadoopV2Task {
}
/** {@inheritDoc} */
- @SuppressWarnings("ConstantConditions")
@Override protected void run0(HadoopV2TaskContext taskCtx) throws IgniteCheckedException {
try {
JobContextImpl jobCtx = taskCtx.jobContext();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2TaskContext.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2TaskContext.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2TaskContext.java
index c362b0c..4557077 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2TaskContext.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/impl/v2/HadoopV2TaskContext.java
@@ -488,7 +488,6 @@ public class HadoopV2TaskContext extends HadoopTaskContext {
* @return Native Hadoop split.
* @throws IgniteCheckedException if failed.
*/
- @SuppressWarnings("unchecked")
public Object getNativeSplit(HadoopInputSplit split) throws IgniteCheckedException {
if (split instanceof HadoopExternalSplit)
return readExternalSplit((HadoopExternalSplit)split);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobTracker.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobTracker.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobTracker.java
index 3331628..f352e5e 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobTracker.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/jobtracker/HadoopJobTracker.java
@@ -232,7 +232,6 @@ public class HadoopJobTracker extends HadoopComponent {
}
/** {@inheritDoc} */
- @SuppressWarnings("deprecation")
@Override public void onKernalStart() throws IgniteCheckedException {
super.onKernalStart();
@@ -303,7 +302,6 @@ public class HadoopJobTracker extends HadoopComponent {
* @param info Job info.
* @return Job completion future.
*/
- @SuppressWarnings("unchecked")
public IgniteInternalFuture<HadoopJobId> submit(HadoopJobId jobId, HadoopJobInfo info) {
if (!busyLock.tryReadLock()) {
return new GridFinishedFuture<>(new IgniteCheckedException("Failed to execute map-reduce job " +
@@ -426,7 +424,6 @@ public class HadoopJobTracker extends HadoopComponent {
* @param meta Metadata.
* @return Status.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public static HadoopJobStatus status(HadoopJobMetadata meta) {
HadoopJobInfo jobInfo = meta.jobInfo();
@@ -548,7 +545,7 @@ public class HadoopJobTracker extends HadoopComponent {
* @param info Task info.
* @param status Task status.
*/
- @SuppressWarnings({"ConstantConditions", "ThrowableResultOfMethodCallIgnored"})
+ @SuppressWarnings({"ConstantConditions"})
public void onTaskFinished(HadoopTaskInfo info, HadoopTaskStatus status) {
if (!busyLock.tryReadLock())
return;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/proto/HadoopProtocolTaskAdapter.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/proto/HadoopProtocolTaskAdapter.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/proto/HadoopProtocolTaskAdapter.java
index c3227ae..2a51b25 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/proto/HadoopProtocolTaskAdapter.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/proto/HadoopProtocolTaskAdapter.java
@@ -74,7 +74,6 @@ public abstract class HadoopProtocolTaskAdapter<R> implements ComputeTask<Hadoop
private Ignite ignite;
/** */
- @SuppressWarnings("UnusedDeclaration")
@JobContextResource
private ComputeJobContext jobCtx;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/HadoopShuffleJob.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/HadoopShuffleJob.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/HadoopShuffleJob.java
index 346362b..3d41e65 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/HadoopShuffleJob.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/HadoopShuffleJob.java
@@ -429,7 +429,6 @@ public class HadoopShuffleJob<T> implements AutoCloseable {
/**
* @param ack Shuffle ack.
*/
- @SuppressWarnings("ConstantConditions")
public void onShuffleAck(HadoopShuffleAck ack) {
IgniteBiTuple<HadoopShuffleMessage, GridFutureAdapter<?>> tup = sentMsgs.get(ack.id());
@@ -473,7 +472,6 @@ public class HadoopShuffleJob<T> implements AutoCloseable {
* @param dest Destination.
* @param jobId Job ID.
*/
- @SuppressWarnings("unchecked")
private void sendFinishResponse(T dest, HadoopJobId jobId) {
if (log.isDebugEnabled())
log.debug("Sent shuffle finish response [jobId=" + jobId + ", dest=" + dest + ']');
@@ -913,7 +911,6 @@ public class HadoopShuffleJob<T> implements AutoCloseable {
* @return Input.
* @throws IgniteCheckedException If failed.
*/
- @SuppressWarnings("unchecked")
public HadoopTaskInput input(HadoopTaskContext taskCtx) throws IgniteCheckedException {
switch (taskCtx.taskInfo().type()) {
case REDUCE:
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/collections/HadoopSkipList.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/collections/HadoopSkipList.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/collections/HadoopSkipList.java
index f300a18..7541186 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/collections/HadoopSkipList.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/shuffle/collections/HadoopSkipList.java
@@ -476,7 +476,6 @@ public class HadoopSkipList extends HadoopMultimapBase {
* @param meta Meta pointer.
* @return Comparison result.
*/
- @SuppressWarnings("unchecked")
private int cmp(Object key, long meta) {
assert meta != 0;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/HadoopRunnableTask.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/HadoopRunnableTask.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/HadoopRunnableTask.java
index 1b19f06..53e211d 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/HadoopRunnableTask.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/HadoopRunnableTask.java
@@ -230,7 +230,6 @@ public abstract class HadoopRunnableTask implements Callable<Void> {
* @return Task input.
* @throws IgniteCheckedException If failed.
*/
- @SuppressWarnings("unchecked")
private HadoopTaskInput createInputInternal(HadoopTaskContext ctx) throws IgniteCheckedException {
switch (ctx.taskInfo().type()) {
case SETUP:
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/child/HadoopChildProcessRunner.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/child/HadoopChildProcessRunner.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/child/HadoopChildProcessRunner.java
index 0278f78..aa31a29 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/child/HadoopChildProcessRunner.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/child/HadoopChildProcessRunner.java
@@ -60,7 +60,6 @@ import static org.apache.ignite.internal.processors.hadoop.HadoopTaskType.REDUCE
/**
* Hadoop process base.
*/
-@SuppressWarnings("FieldAccessedSynchronizedAndUnsynchronized")
public class HadoopChildProcessRunner {
/** Node process descriptor. */
private HadoopProcessDescriptor nodeDesc;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/communication/HadoopExternalCommunication.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/communication/HadoopExternalCommunication.java b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/communication/HadoopExternalCommunication.java
index c5a4f77..73482b6 100644
--- a/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/communication/HadoopExternalCommunication.java
+++ b/modules/hadoop/src/main/java/org/apache/ignite/internal/processors/hadoop/taskexecutor/external/communication/HadoopExternalCommunication.java
@@ -204,7 +204,6 @@ public class HadoopExternalCommunication {
private long maxConnTimeout = DFLT_MAX_CONN_TIMEOUT;
/** Reconnect attempts count. */
- @SuppressWarnings({"FieldAccessedSynchronizedAndUnsynchronized"})
private int reconCnt = DFLT_RECONNECT_CNT;
/** Socket send buffer. */
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/HadoopStartup.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/HadoopStartup.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/HadoopStartup.java
index 66e341b..d8c419f 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/HadoopStartup.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/HadoopStartup.java
@@ -35,7 +35,6 @@ public class HadoopStartup {
/**
* @return Configuration for job run.
*/
- @SuppressWarnings("UnnecessaryFullyQualifiedName")
public static Configuration configuration() {
Configuration cfg = new Configuration();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolMultipleServersSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolMultipleServersSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolMultipleServersSelfTest.java
index 0e5ad03..77d5e8a 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolMultipleServersSelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolMultipleServersSelfTest.java
@@ -54,7 +54,6 @@ import org.apache.ignite.testframework.GridTestUtils;
/**
* Hadoop client protocol configured with multiple ignite servers tests.
*/
-@SuppressWarnings("ResultOfMethodCallIgnored")
public class HadoopClientProtocolMultipleServersSelfTest extends HadoopAbstractSelfTest {
/** Input path. */
private static final String PATH_INPUT = "/input";
@@ -147,7 +146,6 @@ public class HadoopClientProtocolMultipleServersSelfTest extends HadoopAbstractS
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("ConstantConditions")
public void testMultipleAddresses() throws Exception {
restPort = REST_PORT;
@@ -163,7 +161,6 @@ public class HadoopClientProtocolMultipleServersSelfTest extends HadoopAbstractS
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"ConstantConditions", "ThrowableResultOfMethodCallIgnored"})
public void testSingleAddress() throws Exception {
try {
// Don't use REST_PORT to test connection fails if the only this port is configured
@@ -189,7 +186,6 @@ public class HadoopClientProtocolMultipleServersSelfTest extends HadoopAbstractS
/**
* @throws Exception If failed.
*/
- @SuppressWarnings("ConstantConditions")
public void testMixedAddrs() throws Exception {
restPort = REST_PORT;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolSelfTest.java
index 0027b3e..83269e3 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolSelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/client/HadoopClientProtocolSelfTest.java
@@ -136,7 +136,6 @@ public class HadoopClientProtocolSelfTest extends HadoopAbstractSelfTest {
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ConstantConditions")
private void tstNextJobId() throws Exception {
IgniteHadoopClientProtocolProvider provider = provider();
@@ -423,7 +422,6 @@ public class HadoopClientProtocolSelfTest extends HadoopAbstractSelfTest {
* @param path Path.
* @throws Exception If failed.
*/
- @SuppressWarnings("ConstantConditions")
private static void dumpIgfs(IgniteFileSystem igfs, IgfsPath path) throws Exception {
IgfsFile file = igfs.info(path);
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/fs/KerberosHadoopFileSystemFactorySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/fs/KerberosHadoopFileSystemFactorySelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/fs/KerberosHadoopFileSystemFactorySelfTest.java
index f35d644..6554d8e 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/fs/KerberosHadoopFileSystemFactorySelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/fs/KerberosHadoopFileSystemFactorySelfTest.java
@@ -60,7 +60,6 @@ public class KerberosHadoopFileSystemFactorySelfTest extends GridCommonAbstractT
* @param keyTabPrincipal Key tab principal.
* @param reloginInterval Re-login interval.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void checkParameters(String keyTab, String keyTabPrincipal, long reloginInterval) {
final KerberosHadoopFileSystemFactory fac = new KerberosHadoopFileSystemFactory();
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopFIleSystemFactorySelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopFIleSystemFactorySelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopFIleSystemFactorySelfTest.java
index 04ef263..9dcc9c3 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopFIleSystemFactorySelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopFIleSystemFactorySelfTest.java
@@ -115,7 +115,6 @@ public class HadoopFIleSystemFactorySelfTest extends IgfsCommonAbstractTest {
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testCustomFactory() throws Exception {
assert START_CNT.get() == 1;
assert STOP_CNT.get() == 0;
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopSecondaryFileSystemConfigurationTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopSecondaryFileSystemConfigurationTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopSecondaryFileSystemConfigurationTest.java
index 04eaf93..7cc5212 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopSecondaryFileSystemConfigurationTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/HadoopSecondaryFileSystemConfigurationTest.java
@@ -538,7 +538,6 @@ public class HadoopSecondaryFileSystemConfigurationTest extends IgfsCommonAbstra
* @param fs FileSystem to check.
* @param path Path to check.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
private void assertPathDoesNotExist(final FileSystem fs, final Path path) {
GridTestUtils.assertThrows(log, new Callable<Object>() {
@Override public Object call() throws Exception {
http://git-wip-us.apache.org/repos/asf/ignite/blob/9e35993c/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientSelfTest.java
----------------------------------------------------------------------
diff --git a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientSelfTest.java b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientSelfTest.java
index 93f1d05..96ef6bb 100644
--- a/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientSelfTest.java
+++ b/modules/hadoop/src/test/java/org/apache/ignite/internal/processors/hadoop/impl/igfs/IgniteHadoopFileSystemClientSelfTest.java
@@ -139,7 +139,6 @@ public class IgniteHadoopFileSystemClientSelfTest extends IgfsCommonAbstractTest
*
* @throws Exception If failed.
*/
- @SuppressWarnings("ThrowableResultOfMethodCallIgnored")
public void testOutputStreamDeferredException() throws Exception {
final byte[] data = "test".getBytes();
@@ -182,7 +181,6 @@ public class IgniteHadoopFileSystemClientSelfTest extends IgfsCommonAbstractTest
* @param flag Flag state.
* @throws Exception If failed.
*/
- @SuppressWarnings("ConstantConditions")
private void switchHandlerErrorFlag(boolean flag) throws Exception {
IgfsProcessorAdapter igfsProc = ((IgniteKernal)grid(0)).context().igfs();