You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/07/02 08:34:28 UTC

[GitHub] [incubator-shardingsphere] Saisimon commented on a change in pull request #2633: fix #2604

Saisimon commented on a change in pull request #2633: fix #2604
URL: https://github.com/apache/incubator-shardingsphere/pull/2633#discussion_r299364672
 
 

 ##########
 File path: sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/QueryResultUtil.java
 ##########
 @@ -54,7 +54,6 @@ public static Object getValueByColumnType(final ResultSet resultSet, final int c
         ResultSetMetaData metaData = resultSet.getMetaData();
         switch (metaData.getColumnType(columnIndex)) {
             case Types.BIT:
-                return resultSet.getBytes(columnIndex);
 
 Review comment:
   mybatis, postgresql jdbc driver,sql server jdbc driver handle BIT type to BOOLEAN, only MySQL BIT type can store a long value. sharding-sphere should convert the byte array to boolean if this method return byte array, otherwise cause #2604 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services