You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/10 16:51:25 UTC

[GitHub] [netbeans] KacerCZ opened a new pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

KacerCZ opened a new pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665


   https://issues.apache.org/jira/browse/NETBEANS-2843
   
   - Adds PHP debugger option to enable/disable support of resolved breakpoints in Xdebug.
   - Adds new Xdebug feature 'resolved_breakpoints'.
   - Requests use of resolved breakpoints during debug session initialization.
   - Supported by XDebug 2.8 or newer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559123437



##########
File path: php/php.project/src/org/netbeans/modules/php/project/ui/options/PhpOptions.java
##########
@@ -52,6 +53,7 @@
     public static final boolean DEFAULT_DEBUGGER_SHOW_CONSOLE = false;
     public static final boolean DEFAULT_DEBUGGER_STOP_AT_FIRST_LINE = true;
     public static final boolean DEFAULT_DEBUGGER_WATCHES_AND_EVAL = false;
+    public static final boolean DEFAULT_DEBUGGER_RESOLVE_BREAKPOINTS = true;

Review comment:
       Great, thanks for checking it.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559116581



##########
File path: php/php.dbgp/nbproject/project.xml
##########
@@ -180,7 +180,7 @@
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>2.87</specification-version>
+                        <specification-version>2.149</specification-version>

Review comment:
       Thanks for the explanation.
   I increased specification version of `php.dbgp` module.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-759371552


   I had to uncheck the `Stop at First Line` option to verify it.
   Please increment spec version of `php.dbgp` and fix the dependency of `php.project` (project.xml of `php.dbgp`).
   cc: @tmysik 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-759661504


   @junichi11 I updated spec and dependency.
   
   When spec version needs to be changed?
   Is it after change in public package (Project properties > API Versioning > Public Packages)?
   
   Probably spec version of `php.dbgp` should not be changed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 merged pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
junichi11 merged pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559111981



##########
File path: php/php.project/src/org/netbeans/modules/php/project/ui/options/PhpOptions.java
##########
@@ -52,6 +53,7 @@
     public static final boolean DEFAULT_DEBUGGER_SHOW_CONSOLE = false;
     public static final boolean DEFAULT_DEBUGGER_STOP_AT_FIRST_LINE = true;
     public static final boolean DEFAULT_DEBUGGER_WATCHES_AND_EVAL = false;
+    public static final boolean DEFAULT_DEBUGGER_RESOLVE_BREAKPOINTS = true;

Review comment:
       Ubuntu 20.04 is latest LTS and it contains Xdebug 2.9.2.
   https://packages.ubuntu.com/focal/php-xdebug
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-762455647


   @junichi11 @tmysik Thanks for review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559088258



##########
File path: php/php.project/src/org/netbeans/modules/php/project/ui/options/PhpOptions.java
##########
@@ -52,6 +53,7 @@
     public static final boolean DEFAULT_DEBUGGER_SHOW_CONSOLE = false;
     public static final boolean DEFAULT_DEBUGGER_STOP_AT_FIRST_LINE = true;
     public static final boolean DEFAULT_DEBUGGER_WATCHES_AND_EVAL = false;
+    public static final boolean DEFAULT_DEBUGGER_RESOLVE_BREAKPOINTS = true;

Review comment:
       This is probably fine... maybe we could check what Xdebug version is present in the latest Ubuntu LTS?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559087789



##########
File path: php/php.project/src/org/netbeans/modules/php/project/ui/options/PhpDebuggerPanel.form
##########
@@ -349,5 +352,19 @@
         </Property>
       </AccessibilityProperties>
     </Component>
+    <Component class="javax.swing.JCheckBox" name="resolveBreakpointsCheckBox">
+      <Properties>
+        <Property name="text" type="java.lang.String" editor="org.netbeans.modules.i18n.form.FormI18nStringEditor">
+          <ResourceString bundle="org/netbeans/modules/php/project/ui/options/Bundle.properties" key="PhpDebuggerPanel.resolveBreakpointsCheckBox.text" replaceFormat="org.openide.util.NbBundle.getMessage({sourceFileName}.class, &quot;{key}&quot;)"/>
+        </Property>
+      </Properties>
+    </Component>
+    <Component class="javax.swing.JLabel" name="resolveBreakpointsInfoLabel">

Review comment:
       OT: It is usually "better" (more readable) to avoid FQNs in the generated code.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-759763831


   @KacerCZ 
   
   > When spec version needs to be changed?
   > Is it after change in public package (Project properties > API Versioning > Public Packages)?
   > 
   > Probably spec version of `php.dbgp` should not be changed.
   
   Increasing it for Auto update. However, I'm not sure whether UC for dev build is available currently. So, maybe, we should not do it to avoid conflicting with other PRs. Please feel free to revert it. Sorry for my wrong point out. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-761764231


   Once CI finishes, let's merge this PR. Thank you guys.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559123738



##########
File path: php/php.dbgp/nbproject/project.xml
##########
@@ -180,7 +180,7 @@
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>2.87</specification-version>
+                        <specification-version>2.149</specification-version>

Review comment:
       You are welcome.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-759782118


   OK, I reverted change of spec for `php.dbgp`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-761746285


   @KacerCZ @junichi11 
   
   Just added a comment about increasing of specification version. No matter whether there is or is not a DEV update center _currently_, the specification version of PHP Debugger should be increased too (because that is simply correct :)
   
   Thanks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559087931



##########
File path: php/php.project/src/org/netbeans/modules/php/project/ui/options/PhpDebuggerPanel.form
##########
@@ -349,5 +352,19 @@
         </Property>
       </AccessibilityProperties>
     </Component>
+    <Component class="javax.swing.JCheckBox" name="resolveBreakpointsCheckBox">
+      <Properties>
+        <Property name="text" type="java.lang.String" editor="org.netbeans.modules.i18n.form.FormI18nStringEditor">
+          <ResourceString bundle="org/netbeans/modules/php/project/ui/options/Bundle.properties" key="PhpDebuggerPanel.resolveBreakpointsCheckBox.text" replaceFormat="org.openide.util.NbBundle.getMessage({sourceFileName}.class, &quot;{key}&quot;)"/>
+        </Property>
+      </Properties>
+    </Component>
+    <Component class="javax.swing.JLabel" name="resolveBreakpointsInfoLabel">

Review comment:
       Ignore it :arrow_up: , it is XML file... :man_facepalming: 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#discussion_r559088974



##########
File path: php/php.dbgp/nbproject/project.xml
##########
@@ -180,7 +180,7 @@
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>2.87</specification-version>
+                        <specification-version>2.149</specification-version>

Review comment:
       Once this is done, typically also specification version of the module should be increased as well.
   
   Why? If someone uses a daily build which is updated from DEV update center, he will get the new version of PHP project - that is fine. However, since PHP Debugger module has still the same specification version, no update is done. Therefore, functionality from this PR will not work. If the user downloads a fresh daily build, it will work. Therefore, the specification of the PHP Debugger module should be increased too so the user gets its updated version automatically too.
   
   I am not sure where there is any DEV update center but in general, my comment applies.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2665: [NETBEANS-2843] PHP debugger - support for resolved breakpoints

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2665:
URL: https://github.com/apache/netbeans/pull/2665#issuecomment-757512648


   For basic test use this code:
   ```php
   $array = [
       'a',
       'b',
       'c',
   ];
   
   var_dump($array);
   ```
   Set breakpoint at line `$array = [` and debug program.
   Without breakpoint resolution program will not stop.
   With breakpoint resolution program will stop at line `'a'`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists