[GitHub] chewbranca commented on a change in pull request #1593: Couch server improvements

[GitBox <gi...@apache.org>]

chewbranca commented on a change in pull request #1593: Couch server improvements
URL: https://github.com/apache/couchdb/pull/1593#discussion_r215044743
 
 

 ##########
 File path: src/couch/src/couch_server.erl
 ##########
 @@ -101,9 +101,14 @@ open(DbName, Options0) ->
     end.
 
 update_lru(DbName, Options) ->
-    case lists:member(sys_db, Options) of
-        false -> gen_server:cast(couch_server, {update_lru, DbName});
-        true -> ok
+    case config:get_boolean("couchdb", "update_lru_on_read", false) of
 
 Review comment:
   Yeah... I try to pretend that ETS lookup is fast enough to not be relevant. We do config lookups all over the place, so if we're concerned about that I think we need to deal with that as a bigger problem that working around individual lookups. For instance, one option would be to bootstrap new http request pids with a prebuilt config table that has all the options they need to lookup so no concurrent ETS interactions are necessary. Although we would need to do a fair bit of testing to actually determine whether config lookups are a bottleneck.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services