You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2020/05/15 03:29:54 UTC

[GitHub] [lucenenet] bongohrtech commented on a change in pull request #287: Implemenation of "System Properties" in .NET (addresses #254)

bongohrtech commented on a change in pull request #287:
URL: https://github.com/apache/lucenenet/pull/287#discussion_r425546443



##########
File path: src/Lucene.Net.TestFramework/luceneTestSettings.json
##########
@@ -2,7 +2,8 @@
     "analysis.data.dir": "",
     "egothor.stemmer.charset": "UTF-8",
     "kuromoji.data.dir": "",
-    "lucene:version": "4.8.1",
+    "lucene.version": "4.8.1",

Review comment:
       I simply searched for references to SystemProperties.GetProperty and extracted these into the configuration file. Is the danger here that it gets overriden by the file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org