[GitHub] [spark] cloud-fan commented on a change in pull request #31705: [SPARK-34577][SQL] Fix drop/add columns to a dataset of `DESCRIBE NAMESPACE`

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31705:
URL: https://github.com/apache/spark/pull/31705#discussion_r585395262



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -296,10 +296,14 @@ case class DropNamespace(
  */
 case class DescribeNamespace(
     namespace: LogicalPlan,
-    extended: Boolean) extends Command {
+    extended: Boolean,
+    override val output: Seq[Attribute] = DescribeNamespace.getOutputAttr) extends Command {
   override def children: Seq[LogicalPlan] = Seq(namespace)
 
-  override def output: Seq[Attribute] = Seq(
+}
+
+object DescribeNamespace {
+  def getOutputAttr: Seq[Attribute] = Seq(

Review comment:
       the v2 schema is weird: `name: string, value: string`. Shall we follow DESC COLUMN and use `info_name: string, info_value: string`?
   
   v2 command is not stable yet and we can still change it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org