You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by mjsax <gi...@git.apache.org> on 2015/10/07 23:11:24 UTC
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
GitHub user mjsax opened a pull request:
https://github.com/apache/storm/pull/786
[STORM-1095] Tuple.getSourceGlobalStreamid() has wrong camel-case naming
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/storm storm-1095
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #786
----
commit f10b9d4d826ac25b32c1fc92f2da06af873a6cb8
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-10-07T19:24:24Z
[STORM-1095] Tuple.getSourceGlobalStreamid() has wrong camel-case naming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/storm/pull/786#discussion_r41617981
--- Diff: storm-core/src/jvm/backtype/storm/tuple/Tuple.java ---
@@ -37,9 +37,15 @@
/**
* Returns the global stream id (component + stream) of this tuple.
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146361062
Just updated this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146838634
One side question: I linked my own GitHub repo to Travis. However, the build fails very often (even if everything is ok). The Travis build of the Storm repo seems to be much more stable.
For example this build is green, but my personal build of this branch failed: https://travis-ci.org/mjsax/storm/builds/84478972
Do you have any idea why? It is somewhat annoying that I cannot rely on my personal Travis builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/786
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146835431
Thanks for following up, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax closed the pull request at:
https://github.com/apache/storm/pull/786
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146839430
@mjsax
Storm has some kinds of random failures now.
I've been filing failures on https://issues.apache.org/jira/browse/STORM-915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/786#discussion_r41599977
--- Diff: storm-core/src/jvm/backtype/storm/tuple/Tuple.java ---
@@ -37,9 +37,15 @@
/**
* Returns the global stream id (component + stream) of this tuple.
--- End diff --
@mjsax
Could you append comment to explain 'broken naming convention, use getSourceGlobalStreamId() instead'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146341025
Should we consider overloading and deprecating vs. renaming to preserve backwards compatibility for the short term?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146840280
@mjsax Yeah, it would be great. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146351227
@ptgoetz @mjsax
In order to keep backward compatibility, I think we need to decide when to break backward compatibility.
After Storm 0.9.3, seems like we try to respect semver. (Right?)
If I'm right we can say that we'll break backward compatibility for each major version release.
First version would be 1.0.0.
We can mark @Deprecated to legacy with leaving vaild reason and when to remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146343033
It's up to you. I had this issues in mind, too... API breaking changes might be inconvenient/problematic. Just let me know your decision.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by mjsax <gi...@git.apache.org>.
GitHub user mjsax reopened a pull request:
https://github.com/apache/storm/pull/786
[STORM-1095] Tuple.getSourceGlobalStreamid() has wrong camel-case naming
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/storm storm-1095
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #786
----
commit 68d81ab092e76e790da4c69fc9215fd1f2633821
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2015-10-07T19:24:24Z
[STORM-1095] Tuple.getSourceGlobalStreamid() has wrong camel-case naming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1095] Tuple.getSourceGlobalStreamid() h...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/storm/pull/786#issuecomment-146839646
Shall I add failing builds if I encounter them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---