You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2016/12/12 10:20:13 UTC

Review Request 54654: RANGER-1246 : Update UI hints for wildcards in search filters

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54654/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-1246
    https://issues.apache.org/jira/browse/RANGER-1246


Repository: ranger


Description
-------

Added help text to reflect whether wildcard is supported or not.


Diffs
-----

  security-admin/src/main/webapp/scripts/modules/XAOverrides.js 8122ae1 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 99a5424 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js c05dcf3 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 14ac70b 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 8dc3485 
  security-admin/src/main/webapp/styles/xa.css 264e0ea 
  security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html eab1c22 

Diff: https://reviews.apache.org/r/54654/diff/


Testing
-------

**Testing done**


* Verified updated UI hints for each search filter. It shows message of whether wild cards are supported for search filters.
* Also verified alert on update policy for Hive - having UDF resource for masking type policy (shows info alert message to provide access to resource from access based policies).


Thanks,

Gautam Borad


Re: Review Request 54654: RANGER-1246 : Update UI hints for wildcards in search filters

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54654/#review159115
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Dec. 12, 2016, 10:20 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54654/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 10:20 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1246
>     https://issues.apache.org/jira/browse/RANGER-1246
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added help text to reflect whether wildcard is supported or not.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/XAOverrides.js 8122ae1 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 99a5424 
>   security-admin/src/main/webapp/scripts/utils/XAEnums.js c05dcf3 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js 14ac70b 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 8dc3485 
>   security-admin/src/main/webapp/styles/xa.css 264e0ea 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html eab1c22 
> 
> Diff: https://reviews.apache.org/r/54654/diff/
> 
> 
> Testing
> -------
> 
> **Testing done**
> 
> 
> * Verified updated UI hints for each search filter. It shows message of whether wild cards are supported for search filters.
> * Also verified alert on update policy for Hive - having UDF resource for masking type policy (shows info alert message to provide access to resource from access based policies).
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 54654: RANGER-1246 : Update UI hints for wildcards in search filters

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54654/#review159525
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Dec. 16, 2016, 8:33 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54654/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2016, 8:33 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1246
>     https://issues.apache.org/jira/browse/RANGER-1246
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added help text to reflect whether wildcard is supported or not.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/modules/XAOverrides.js 8122ae1 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 63a5b0f 
>   security-admin/src/main/webapp/scripts/utils/XAEnums.js c05dcf3 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js c026b52 
>   security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 76dc027 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 8dc3485 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 964d263 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js bf00a7e 
>   security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 39770d9 
>   security-admin/src/main/webapp/styles/xa.css 7d86dfa 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html eab1c22 
> 
> Diff: https://reviews.apache.org/r/54654/diff/
> 
> 
> Testing
> -------
> 
> **Testing done**
> 
> 
> * Verified updated UI hints for each search filter. It shows message of whether wild cards are supported for search filters.
> * Also verified alert on update policy for Hive - having UDF resource for masking type policy (shows info alert message to provide access to resource from access based policies).
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 54654: RANGER-1246 : Update UI hints for wildcards in search filters

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54654/
-----------------------------------------------------------

(Updated Dec. 16, 2016, 8:33 a.m.)


Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep Agrawal, and Velmurugan Periasamy.


Changes
-------

Text changes for UI hints and solution of positioning of hint popup.


Bugs: RANGER-1246
    https://issues.apache.org/jira/browse/RANGER-1246


Repository: ranger


Description
-------

Added help text to reflect whether wildcard is supported or not.


Diffs (updated)
-----

  security-admin/src/main/webapp/scripts/modules/XAOverrides.js 8122ae1 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 63a5b0f 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js c05dcf3 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js c026b52 
  security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js 76dc027 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 8dc3485 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 964d263 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js bf00a7e 
  security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js 39770d9 
  security-admin/src/main/webapp/styles/xa.css 7d86dfa 
  security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html eab1c22 

Diff: https://reviews.apache.org/r/54654/diff/


Testing
-------

**Testing done**


* Verified updated UI hints for each search filter. It shows message of whether wild cards are supported for search filters.
* Also verified alert on update policy for Hive - having UDF resource for masking type policy (shows info alert message to provide access to resource from access based policies).


Thanks,

Gautam Borad


Re: Review Request 54654: RANGER-1246 : Update UI hints for wildcards in search filters

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54654/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 10:03 a.m.)


Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Pradeep Agrawal, and Velmurugan Periasamy.


Changes
-------

Rebased patch from RANGER-1237


Bugs: RANGER-1246
    https://issues.apache.org/jira/browse/RANGER-1246


Repository: ranger


Description
-------

Added help text to reflect whether wildcard is supported or not.


Diffs (updated)
-----

  security-admin/src/main/webapp/scripts/modules/XAOverrides.js 8122ae1 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 63a5b0f 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js c05dcf3 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js c026b52 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 8dc3485 
  security-admin/src/main/webapp/styles/xa.css 7d86dfa 
  security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html eab1c22 

Diff: https://reviews.apache.org/r/54654/diff/


Testing
-------

**Testing done**


* Verified updated UI hints for each search filter. It shows message of whether wild cards are supported for search filters.
* Also verified alert on update policy for Hive - having UDF resource for masking type policy (shows info alert message to provide access to resource from access based policies).


Thanks,

Gautam Borad