You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/06/30 22:10:09 UTC
Review Request 36063: Make e2e test fail when a command fails.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1378
https://issues.apache.org/jira/browse/AURORA-1378
Repository: aurora
Description
-------
Make e2e test fail correctly.
This doesn't fix the test (still investigating the root cause there), but causes it to be properly broken.
Diffs
-----
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 79377c387232269094029314b677afeb21ee46ea
Diff: https://reviews.apache.org/r/36063/diff/
Testing
-------
+ grep -q 'shiro_audit_logging_enabled 1'
+ curl -s localhost:8081/vars
+ tear_down 1
+ local retcode=1
+ sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json
+ sudo stop aurora-scheduler-kerberos
aurora-scheduler-kerberos stop/waiting
+ sudo rm -f /etc/init/aurora-scheduler-kerberos.conf
+ sudo start aurora-scheduler
aurora-scheduler start/running, process 13559
+ [[ 1 -ne 0 ]]
+ echo
+ echo '!!! FAILED'
!!! FAILED
+ echo
Thanks,
Kevin Sweeney
Re: Review Request 36063: Make e2e test fail when a command fails.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/#review89963
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On June 30, 2015, 8:10 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36063/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 8:10 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1378
> https://issues.apache.org/jira/browse/AURORA-1378
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make e2e test fail correctly.
>
> This doesn't fix the test (still investigating the root cause there), but causes it to be properly broken.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 79377c387232269094029314b677afeb21ee46ea
>
> Diff: https://reviews.apache.org/r/36063/diff/
>
>
> Testing
> -------
>
> ```
> + + grep -q 'shiro_audit_logging_enabled 1'
> + curl -s localhost:8081/vars
> + tear_down 1
> + local retcode=1
> + sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json
> + sudo stop aurora-scheduler-kerberos
> aurora-scheduler-kerberos stop/waiting
> + sudo rm -f /etc/init/aurora-scheduler-kerberos.conf
> + sudo start aurora-scheduler
> aurora-scheduler start/running, process 13559
> + [[ 1 -ne 0 ]]
> + echo
>
> + echo '!!! FAILED'
> !!! FAILED
> + echo
> ```
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 36063: Make e2e test fail when a command fails.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/#review89959
-----------------------------------------------------------
Ship it!
Master (616ef10) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 30, 2015, 8:10 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36063/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 8:10 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1378
> https://issues.apache.org/jira/browse/AURORA-1378
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make e2e test fail correctly.
>
> This doesn't fix the test (still investigating the root cause there), but causes it to be properly broken.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 79377c387232269094029314b677afeb21ee46ea
>
> Diff: https://reviews.apache.org/r/36063/diff/
>
>
> Testing
> -------
>
> ```
> + + grep -q 'shiro_audit_logging_enabled 1'
> + curl -s localhost:8081/vars
> + tear_down 1
> + local retcode=1
> + sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json
> + sudo stop aurora-scheduler-kerberos
> aurora-scheduler-kerberos stop/waiting
> + sudo rm -f /etc/init/aurora-scheduler-kerberos.conf
> + sudo start aurora-scheduler
> aurora-scheduler start/running, process 13559
> + [[ 1 -ne 0 ]]
> + echo
>
> + echo '!!! FAILED'
> !!! FAILED
> + echo
> ```
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 36063: Make e2e test fail when a command fails.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/#review91643
-----------------------------------------------------------
Kevin - is this ready to land?
- Bill Farner
On June 30, 2015, 8:10 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36063/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 8:10 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1378
> https://issues.apache.org/jira/browse/AURORA-1378
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make e2e test fail correctly.
>
> This doesn't fix the test (still investigating the root cause there), but causes it to be properly broken.
>
>
> Diffs
> -----
>
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 79377c387232269094029314b677afeb21ee46ea
>
> Diff: https://reviews.apache.org/r/36063/diff/
>
>
> Testing
> -------
>
> ```
> + + grep -q 'shiro_audit_logging_enabled 1'
> + curl -s localhost:8081/vars
> + tear_down 1
> + local retcode=1
> + sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json
> + sudo stop aurora-scheduler-kerberos
> aurora-scheduler-kerberos stop/waiting
> + sudo rm -f /etc/init/aurora-scheduler-kerberos.conf
> + sudo start aurora-scheduler
> aurora-scheduler start/running, process 13559
> + [[ 1 -ne 0 ]]
> + echo
>
> + echo '!!! FAILED'
> !!! FAILED
> + echo
> ```
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 36063: Make e2e test fail when a command fails.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/
-----------------------------------------------------------
(Updated June 30, 2015, 1:10 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-1378
https://issues.apache.org/jira/browse/AURORA-1378
Repository: aurora
Description
-------
Make e2e test fail correctly.
This doesn't fix the test (still investigating the root cause there), but causes it to be properly broken.
Diffs
-----
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 79377c387232269094029314b677afeb21ee46ea
Diff: https://reviews.apache.org/r/36063/diff/
Testing (updated)
-------
```
+ + grep -q 'shiro_audit_logging_enabled 1'
+ curl -s localhost:8081/vars
+ tear_down 1
+ local retcode=1
+ sudo cp /vagrant/examples/vagrant/clusters.json /etc/aurora/clusters.json
+ sudo stop aurora-scheduler-kerberos
aurora-scheduler-kerberos stop/waiting
+ sudo rm -f /etc/init/aurora-scheduler-kerberos.conf
+ sudo start aurora-scheduler
aurora-scheduler start/running, process 13559
+ [[ 1 -ne 0 ]]
+ echo
+ echo '!!! FAILED'
!!! FAILED
+ echo
```
Thanks,
Kevin Sweeney