You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/08 19:45:47 UTC

[GitHub] [arrow] domoritz commented on a change in pull request #10275: ARROW-12702: [JS] Update webpack and terser

domoritz commented on a change in pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#discussion_r628788988



##########
File path: js/gulp/minify-task.js
##########
@@ -62,13 +63,10 @@ const minifyTask = ((cache, commonConfig) => memoizeTask(cache, function minifyJ
             minimize: true,
             minimizer: [
                 new TerserPlugin({
-                    sourceMap: true,
                     terserOptions: {
                         ecma: terserLanguageNames[target],
-                        output: { comments: false, beautify: false },
-                        compress: { unsafe: true },
-                        mangle: true,
-                        safari10: true // <-- works around safari10 bugs, see the "safari10" option here: https://github.com/terser-js/terser#minify-options

Review comment:
       Safari 10 is sufficiently old enough that we don't need this anymore. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org