You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/11 08:44:21 UTC
[GitHub] [lucene-solr] janhoy opened a new pull request #1250: SOLR-14250
Fix error logging on Expect: 100-continue
janhoy opened a new pull request #1250: SOLR-14250 Fix error logging on Expect: 100-continue
URL: https://github.com/apache/lucene-solr/pull/1250
See https://issues.apache.org/jira/browse/SOLR-14250
With this PR, we'll still always try to consume the stream,
but if the input stream is not available due to Expect: header,
and an error has already been sent by Solr, the resulting IOException
from Jetty will not be logged at INFO level but instead be a simple
line on DEBUG level.
The PR does not try to add a test to validate behaviour
since this is a logging change only, so there is no risk
that the stream is not consumed anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy merged pull request #1250: SOLR-14250 Fix
error logging on Expect: 100-continue
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #1250: SOLR-14250 Fix error logging on Expect: 100-continue
URL: https://github.com/apache/lucene-solr/pull/1250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on issue #1250: SOLR-14250 Fix error
logging on Expect: 100-continue
Posted by GitBox <gi...@apache.org>.
janhoy commented on issue #1250: SOLR-14250 Fix error logging on Expect: 100-continue
URL: https://github.com/apache/lucene-solr/pull/1250#issuecomment-584537676
I tested manually that the new DEBUG log line is printed when hitting a non-existent URL, e.g.
curl -H "Content-Type: application/json" -H "Expect: 100-continue" http://localhost:8983/solr/foo/update2
So I think this is good to go. Will leave it sitting here to collect feedback for a few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org