You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/17 20:21:54 UTC

[GitHub] [spark] igorcalabria opened a new pull request #26152: [SPARK-27812][K8S][2.4] Bump K8S client version to 4.6.1

igorcalabria opened a new pull request #26152: [SPARK-27812][K8S][2.4] Bump K8S client version to 4.6.1
URL: https://github.com/apache/spark/pull/26152
 
 
   # What changes were proposed in this pull request?
   
   Backport of #26093 to `branch-2.4`
   
   ### Why are the changes needed?
   
   https://issues.apache.org/jira/browse/SPARK-27812
   https://issues.apache.org/jira/browse/SPARK-27927
   
   We need this fix https://github.com/fabric8io/kubernetes-client/pull/1768 that was released on version 4.6 of the client. The root cause of the problem is better explained in https://github.com/apache/spark/pull/25785
   
   ### Does this PR introduce any user-facing change?
   
   No
   
   ### How was this patch tested?
   
   This patch was tested manually using a simple pyspark job
   
   ```python
   from pyspark.sql import SparkSession
   
   if __name__ == '__main__':
       spark = SparkSession.builder.getOrCreate()
   ```
   
   The expected behaviour of this "job" is that both python's and jvm's process exit automatically after the main runs. This is the case for spark versions <= 2.4. On version 2.4.3, the jvm process hangs because there's a non daemon thread running 
   
   ```
   "OkHttp WebSocket https://10.96.0.1/..." #121 prio=5 os_prio=0 tid=0x00007fb27c005800 nid=0x24b waiting on condition [0x00007fb300847000]
   "OkHttp WebSocket https://10.96.0.1/..." #117 prio=5 os_prio=0 tid=0x00007fb28c004000 nid=0x247 waiting on condition [0x00007fb300e4b000]
   ```
   This is caused by a bug on `kubernetes-client` library, which is fixed on the version that we are upgrading to.
   
   When the mentioned job is run with this patch applied, the behaviour from spark <= 2.4.0 is restored and both processes terminate successfully  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org